Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use explicit relative cimports in cython files #22214

Closed
a-andre opened this issue Jan 19, 2017 · 9 comments
Closed

use explicit relative cimports in cython files #22214

a-andre opened this issue Jan 19, 2017 · 9 comments

Comments

@a-andre
Copy link

a-andre commented Jan 19, 2017

to fix some compile errors when using cython's language_level 3.

Component: python3

Author: André Apitzsch

Branch/Commit: 5ddec3a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22214

@a-andre a-andre added this to the sage-7.6 milestone Jan 19, 2017
@a-andre
Copy link
Author

a-andre commented Jan 19, 2017

Branch: u/aapitzsch/22214

@a-andre
Copy link
Author

a-andre commented Jan 19, 2017

Commit: 5ddec3a

@a-andre
Copy link
Author

a-andre commented Jan 19, 2017

New commits:

5ddec3ause explicit relative cimport in cython files

@jdemeyer
Copy link

comment:2

I think that you should add

from __future__ import absolute_import

to all those files to prevent regressions.

@fchapoton
Copy link
Contributor

comment:3

I agree with Jeroen, please add the future imports.

How did you discover these compiling errors ? Could you please explain ?

@a-andre
Copy link
Author

a-andre commented Jan 20, 2017

comment:4

Replying to @fchapoton:

I agree with Jeroen, please add the future imports.

How did you discover these compiling errors ? Could you please explain ?

I added 'language_level': 3, to the compiler directives in src/setup.py (about line 405).

@tscrim
Copy link
Collaborator

tscrim commented Jan 20, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 20, 2017

comment:5

Patchbot is (essentially) green, so positive review.

@vbraun
Copy link
Member

vbraun commented Jan 23, 2017

Changed branch from u/aapitzsch/22214 to 5ddec3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants