New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Sandpiles thematic tutorial #22264
Comments
New commits:
|
Commit: |
comment:3
Some changes made, more to come... |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Does the "no larger" mean "less or equal", or does it really mean "not larger"? (Due to the tacit all-quantor here, this makes a difference.)
Am I seeing it right that the b has nothing to do with c? Because the "with" suggests that it does, but I'm not sure what... |
Reviewer: Darij Grinberg |
comment:7
Two things I see from a quick look:
For comment:5. I don't see the difference since I am interpreting it as something compared component-by-component. My guess is that |
comment:8
Thanks! The "accessible" is defined further above in that .rst file, so I thought it makes sense. But I'll add both wordings. Yes, b and c have nothing to do with each other, as I've just found out from http://www.dam.brown.edu/people/cklivans/Dynkin.pdf . And the "no larger" is indeed componentwise (Theorem 2.28 in https://arxiv.org/pdf/1112.6163.pdf ). I will clarify these tomorrow when I am back on a Linux machine. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
I don't understand what Also, how can this be true?
The circle |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
I'm done with my review of everything up until the "methods" section. What remains are the two questions in comment:10; also, what exactly is the Tutte polynomial? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
ping |
comment:15
Wait, that's a ping to myself... The short answer is I have no idea. I was just trying to clean it a little bit. |
comment:28
And I thought we were becoming unicode-compatible with py3 :) |
comment:29
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:31
Alright, let's see now. |
comment:32
Still fails |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:34
This should fix the doctests output because I explicitly copied the expected output. I also enabled utf8 encoding on the thematic tutorial and put back the unicode characters. |
comment:35
"Should fix" or "I tested that it fixes"? |
comment:36
"I tested that it fixes" on my machine. :) |
Changed branch from public/doc/fix_sandpile_tutorial-22264 to |
There are a number of things that could use some polish. This is just to fix the issues I see.
CC: @sagetrac-dperkinson
Component: documentation
Author: Travis Scrimshaw
Branch/Commit:
e7d9fb4
Reviewer: Darij Grinberg
Issue created by migration from https://trac.sagemath.org/ticket/22264
The text was updated successfully, but these errors were encountered: