Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ob_size does not exist in Python 3 #22291

Closed
jdemeyer opened this issue Feb 2, 2017 · 8 comments
Closed

ob_size does not exist in Python 3 #22291

jdemeyer opened this issue Feb 2, 2017 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@jdemeyer
Copy link

jdemeyer commented Feb 2, 2017

Replace direct access of the ob_size member of a PyObject* by the macro Py_SIZE(). Also use Cython's longintrepr.pxd instead of manually including longintrepr.h.

This is used in

  • src/sage/libs/cypari2/convert.pyx
  • src/sage/libs/gmp/pylong.pyx

CC: @defeo @videlec @fchapoton

Component: python3

Author: Jeroen Demeyer

Branch/Commit: b5f74b1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22291
@jdemeyer jdemeyer added this to the sage-7.6 milestone Feb 2, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

jdemeyer commented Feb 3, 2017

Branch: u/jdemeyer/ob_size_does_not_exist_in_python_3

@jdemeyer
Copy link
Author

jdemeyer commented Feb 3, 2017

New commits:

b5f74b1Use longintrepr.pxd from Cython

@jdemeyer
Copy link
Author

jdemeyer commented Feb 3, 2017

Commit: b5f74b1

@fchapoton
Copy link
Contributor

comment:5

ok, lgtm and bot is green

@jdemeyer
Copy link
Author

jdemeyer commented Feb 4, 2017

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Feb 5, 2017

Changed branch from u/jdemeyer/ob_size_does_not_exist_in_python_3 to b5f74b1

@vbraun vbraun closed this as completed in 10f07b2 Feb 5, 2017
@jdemeyer jdemeyer mentioned this issue Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton