Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3 : no .iteritems in combinat/ #22298

Closed
fchapoton opened this issue Feb 3, 2017 · 16 comments
Closed

py3 : no .iteritems in combinat/ #22298

fchapoton opened this issue Feb 3, 2017 · 16 comments

Comments

@fchapoton
Copy link
Contributor

as a step to python3

use the six.iteritems instead, here just in combinat/

change done using the script "iteritems" from "sixer"

https://github.com/haypo/sixer

part of #15981

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 4802315

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/22298

@fchapoton fchapoton added this to the sage-7.6 milestone Feb 3, 2017
@fchapoton
Copy link
Contributor Author

New commits:

8fe2a8apy3: get rid of .iteritems in combinat folder

@fchapoton
Copy link
Contributor Author

Commit: 8fe2a8a

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22298

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2017

Changed commit from 8fe2a8a to f590c67

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

f590c67trac 2229_ manual fixing for .iteritems removal in combinat

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 5, 2017

comment:3

What about

elt = dict({ x for x in dict(HLP(m(la))).iteritems() if x[0] in self._kbounded_partitions })

in src/sage/combinat/sf/k_dual.py?

I can review this one.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 6, 2017

comment:4

Seems to be OK and tests passed. Feel free to mark as positive_review now, of check src/sage/combinat/sf/k_dual.py, whichever you want.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 6, 2017

Reviewer: Jori Mäntysalo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

d8a6c8dtrac 22298 fixing 2 missing cases of iteritems in combinat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2017

Changed commit from f590c67 to d8a6c8d

@fchapoton
Copy link
Contributor Author

comment:6

Thank you, Jori.

I have found another missing case, and treated it too.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 6, 2017

comment:7

Typo: parenthesis at the end of

for (nn,lmbda,mu,uu),(kk,f) in iteritems(QDM[n,1]))

@jm58660 jm58660 mannequin added s: needs work and removed s: needs review labels Feb 6, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2017

Changed commit from d8a6c8d to 4802315

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

4802315trac 22298 syntax error

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 6, 2017

comment:9

Works now.

@jm58660 jm58660 mannequin added s: positive review and removed s: needs work labels Feb 6, 2017
@vbraun
Copy link
Member

vbraun commented Feb 8, 2017

Changed branch from u/chapoton/22298 to 4802315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants