Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

range() -> list(xrange()) in graphs Cython files #22352

Closed
jdemeyer opened this issue Feb 11, 2017 · 8 comments
Closed

range() -> list(xrange()) in graphs Cython files #22352

jdemeyer opened this issue Feb 11, 2017 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@jdemeyer
Copy link

CC: @fchapoton

Component: python3

Author: Jeroen Demeyer

Branch/Commit: 45deabb

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22352
@jdemeyer jdemeyer added this to the sage-7.6 milestone Feb 11, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/range______list_xrange____in_graphs_cython_files

@jdemeyer
Copy link
Author

New commits:

45deabbrange(n) -> list(xrange(n)) in Cython files

@jdemeyer
Copy link
Author

Commit: 45deabb

@fchapoton
Copy link
Contributor

comment:3

Could you elaborate on why ?

@jdemeyer
Copy link
Author

comment:4

Replying to @fchapoton:

Could you elaborate on why ?

To keep the current Python 2 behaviour for range().

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:5

ok, let it be.

@vbraun
Copy link
Member

vbraun commented Feb 12, 2017

Changed branch from u/jdemeyer/range______list_xrange____in_graphs_cython_files to 45deabb

@vbraun vbraun closed this as completed in af93b5f Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton