Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.7.5 #22364

Closed
rwst opened this issue Feb 12, 2017 · 24 comments
Closed

Upgrade to pynac-0.7.5 #22364

rwst opened this issue Feb 12, 2017 · 24 comments

Comments

@rwst
Copy link

rwst commented Feb 12, 2017

Pynac-0.7.5 has

https://github.com/pynac/pynac/releases/download/pynac-0.7.5/pynac-0.7.5.tar.bz2

Depends on #22421

Component: packages: standard

Author: Ralf Stephan

Branch: 8d7801e

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/22364

@rwst rwst added this to the sage-7.6 milestone Feb 12, 2017
@rwst
Copy link
Author

rwst commented Feb 12, 2017

Branch: u/rws/upgrade_to_pynac_0_7_5

@rwst
Copy link
Author

rwst commented Feb 12, 2017

Changed branch from u/rws/upgrade_to_pynac_0_7_5 to none

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Feb 12, 2017

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Feb 12, 2017

Commit: 46697e0

@rwst
Copy link
Author

rwst commented Feb 12, 2017

New commits:

46697e0pkg version/chksum

@rwst
Copy link
Author

rwst commented Feb 12, 2017

Branch: u/rws/upgrade_to_pynac_0_7_5

@vbraun
Copy link
Member

vbraun commented Feb 14, 2017

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Feb 17, 2017

comment:6
sage -t --long --warn-long 79.1 src/sage/functions/orthogonal_polys.py
**********************************************************************
File "src/sage/functions/orthogonal_polys.py", line 1884, in sage.functions.orthogonal_polys.Func_jacobi_P._eval_
Failed example:
    jacobi_P(1,n,n,n)
Expected:
    (n + 1)*n
Got:
    (n + 1)*((n - 1)*gamma(2*n + 2)/gamma(n + 1) + gamma(2*n + 2)/gamma(n + 1))*gamma(n + 1)/gamma(2*n + 2)
**********************************************************************
File "src/sage/functions/orthogonal_polys.py", line 1888, in sage.functions.orthogonal_polys.Func_jacobi_P._eval_
Failed example:
    jacobi_P(1,n,n,x)
Expected:
    (n + 1)*x
Got:
    (n + 1)*((x - 1)*gamma(2*n + 2)/gamma(n + 1) + gamma(2*n + 2)/gamma(n + 1))*gamma(n + 1)/gamma(2*n + 2)
**********************************************************************
1 item had failures:
   2 of  13 in sage.functions.orthogonal_polys.Func_jacobi_P._eval_
    [378 tests, 2 failures, 7.87 s]
----------------------------------------------------------------------
sage -t --long --warn-long 79.1 src/sage/functions/orthogonal_polys.py  # 2 doctests failed
----------------------------------------------------------------------
Total time for all tests: 8.1 seconds
    cpu time: 5.3 seconds
    cumulative wall time: 7.9 seconds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

20f0b48Merge branch 'develop' into t/22364/upgrade_to_pynac_0_7_5
328095722364: add normalization step to jacobi_P.eval

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2017

Changed commit from 46697e0 to 3280957

@vbraun
Copy link
Member

vbraun commented Feb 23, 2017

comment:10

I'm getting this on 32-bit

sage -t --long src/sage/functions/orthogonal_polys.py
**********************************************************************
File "src/sage/functions/orthogonal_polys.py", line 1886, in sage.functions.orthogonal_polys.Func_jacobi_P._eval_
Failed example:
    jacobi_P(2,n,n,n)
Expected:
    1/4*(2*n - 1)*(n + 2)*(n + 1)^2
Got:
    1/4*(2*n^2 + n - 1)*(n + 2)*(n + 1)
**********************************************************************
1 item had failures:
   1 of  13 in sage.functions.orthogonal_polys.Func_jacobi_P._eval_
    [378 tests, 1 failure, 8.03 s]

@vbraun
Copy link
Member

vbraun commented Feb 23, 2017

comment:11

There are some more, possibly related to #22057

sage -t --long src/sage/symbolic/expression.pyx
**********************************************************************
File "src/sage/symbolic/expression.pyx", line 6729, in sage.symbolic.expression.Expression.resultant
Failed example:
    (x+y).resultant(x-y, x)
Expected:
    -2*y
Got:
    2*x
**********************************************************************
File "src/sage/symbolic/expression.pyx", line 6732, in sage.symbolic.expression.Expression.resultant
Failed example:
    r.coefficient(a^4)
Expected:
    b^4*y^2 - 4*b^3*y^3 + 6*b^2*y^4 - 4*b*y^5 + y^6
Got:
    0
**********************************************************************
1 item had failures:
   2 of   7 in sage.symbolic.expression.Expression.resultant
    [2670 tests, 2 failures, 35.16 s]

@rwst
Copy link
Author

rwst commented Feb 23, 2017

comment:13

What's the easiest way to build a 32bit Sage for debugging this? Volker, can you give me an account?

@rwst
Copy link
Author

rwst commented Feb 23, 2017

comment:14

Hold on, I confirm there is a problem with resultants when I merge #22057 into this.,

@rwst
Copy link
Author

rwst commented Feb 23, 2017

comment:15

As there were 32bit problems with Giac I think it would be safer if we used Singular on 32bit instead. Fortunately I provided for such build-time switching. Now this should just be a matter of spkg-install...

@jdemeyer
Copy link

Dependencies: #22421

@rwst
Copy link
Author

rwst commented Feb 25, 2017

comment:17

On the other hand failure on 32 bit indicates underlying bugs so, sadly, I'll switch off Giac support again until #22101 and #22280 have been sorted out and then try again. If the 32 bit problems persist then at least we know it's not Giac in this case.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 25, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

7cdbdb022421: apply commit from (future) Pynac master
0a7335922421: clean up spkg-install
58f10d5Merge branch 'u/rws/pynac_s_to_gamma___is_buggy' of git://trac.sagemath.org/sage into t/22364/upgrade_to_pynac_0_7_5
8d7801e22364: turn off Giac usage of Pynac

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 25, 2017

Changed commit from 3280957 to 8d7801e

@vbraun
Copy link
Member

vbraun commented Mar 1, 2017

Changed branch from u/rws/upgrade_to_pynac_0_7_5 to 8d7801e

@kiwifb
Copy link
Member

kiwifb commented Mar 5, 2017

Changed commit from 8d7801e to none

@kiwifb
Copy link
Member

kiwifb commented Mar 5, 2017

comment:22

Something weird is happening to me here in sage-on-gentoo. Tests were OK after merging of this and #22057. Now that we have moved past 7.6.beta6 (I work off Volker's tree usually) I have the failures in symbolic/expression.pyx and functions/orthogonal_polys.py again. For the later it is even stranger, I get the failure only the first time I run the test, subsequent testing of functions/orthogonal_polys.py pass but not symbolic/expression.pyx.

Could it be caused by ginac, since I still have it enabled in pynac? But why would it re-appear after 7.6.beta6 has been released?

@rwst
Copy link
Author

rwst commented Mar 5, 2017

comment:23

Replying to @kiwifb:

Could it be caused by ginac, since I still have it enabled in pynac? But why would it re-appear after 7.6.beta6 has been released?

Giac? Yes that's why I disabled it again (comment:17). On the other hand if the problems persist even when you disable it too, then please open a ticket because that would be unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants