Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FGP_Element: cmp -> richcmp #22369

Closed
jdemeyer opened this issue Feb 12, 2017 · 7 comments
Closed

FGP_Element: cmp -> richcmp #22369

jdemeyer opened this issue Feb 12, 2017 · 7 comments

Comments

@jdemeyer
Copy link

CC: @mezzarobba @fchapoton

Component: python3

Author: Marc Mezzarobba

Branch/Commit: 28ca821

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/22369

@jdemeyer jdemeyer added this to the sage-7.6 milestone Feb 12, 2017
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

28ca821FGP_Element: cmp -> richcmp

@jdemeyer
Copy link
Author

Commit: 28ca821

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

comment:4

Positive review if tests pass (I did not check).

@fchapoton
Copy link
Contributor

comment:5

tests ok

@vbraun
Copy link
Member

vbraun commented Feb 16, 2017

Changed branch from u/jdemeyer/fgp_element__cmp____richcmp to 28ca821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants