Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use V=1 for logfiles #22418

Closed
jdemeyer opened this issue Feb 23, 2017 · 12 comments
Closed

Always use V=1 for logfiles #22418

jdemeyer opened this issue Feb 23, 2017 · 12 comments

Comments

@jdemeyer
Copy link

With #21539, Sage globally supports a V=0 mode. In this mode, the individual logfiles are created with V=1. But this leads to surprising behaviour because some packages have V=0 by default. So a build with V=0 can actually be more verbose than a build with V unset.

Instead, always unconditionally use V=1 for individual packages.

CC: @mkoeppe

Component: build

Author: Jeroen Demeyer

Branch: dcc3ba5

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/22418

@jdemeyer jdemeyer added this to the sage-7.6 milestone Feb 23, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: dcc3ba5

@jdemeyer
Copy link
Author

New commits:

dcc3ba5Always use V=1 for logfiles

@mkoeppe
Copy link
Member

mkoeppe commented Feb 24, 2017

comment:7

This looks fine; but I just noticed that (with or without this ticket) this works for V=0 make but not for make V=0 because in the latter case MAKEFLAGS is set to V=0 and can't be overridden by the environment variable.

@jdemeyer
Copy link
Author

comment:8

Replying to @mkoeppe:

This looks fine; but I just noticed that (with or without this ticket) this works for V=0 make but not for make V=0 because in the latter case MAKEFLAGS is set to V=0 and can't be overridden by the environment variable.

That is a different issue which is unrelated to this ticket.

@mkoeppe
Copy link
Member

mkoeppe commented Feb 24, 2017

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Mar 1, 2017

Changed branch from u/jdemeyer/always_use_v_1_for_logfiles to dcc3ba5

@mkoeppe
Copy link
Member

mkoeppe commented Mar 2, 2017

comment:11

Follow-up: #22492

@mkoeppe
Copy link
Member

mkoeppe commented Mar 2, 2017

Changed commit from dcc3ba5 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants