Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctest continuation marker / several files / 3 #22465

Closed
jm58660 mannequin opened this issue Feb 27, 2017 · 9 comments
Closed

Doctest continuation marker / several files / 3 #22465

jm58660 mannequin opened this issue Feb 27, 2017 · 9 comments
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-7.6

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Feb 27, 2017

This is the last patch about doctest continuation markers at src/sage. (There are some left at src/doc.)

In few cases this corrects a bug where a doctest does not really check for right output.

CC: @tscrim

Component: documentation

Keywords: days85

Author: Jori Mäntysalo

Branch/Commit: 4e7d27a

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/22465
@jm58660 jm58660 mannequin added this to the sage-7.6 milestone Feb 27, 2017
@jm58660 jm58660 mannequin added c: documentation labels Feb 27, 2017
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Feb 27, 2017

Branch: u/jmantysalo/doctest-continuation-last

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Feb 27, 2017

comment:2

Is it possible to forbid old-style continuation markers? That would prevent some doctest errors.

New commits:

4db20c0Last doctest continuation marker change on src/sage.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Feb 27, 2017

Commit: 4db20c0

@jm58660 jm58660 mannequin added the s: needs review label Feb 27, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2017

Changed commit from 4db20c0 to 4e7d27a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

4e7d27aMerge branch 'develop' into t/22465/doctest-continuation-last

@saraedum
Copy link
Member

comment:4

I am happy with this, assuming that the patchbots do not complain.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@saraedum
Copy link
Member

Changed keywords from none to days85

@vbraun
Copy link
Member

vbraun commented Apr 3, 2017

Changed branch from u/jmantysalo/doctest-continuation-last to 4e7d27a

@vbraun vbraun closed this as completed in 2b13d2c Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
2 participants
@saraedum @vbraun