Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 get rid of last call to cmp() in parent.pyx #22484

Closed
fchapoton opened this issue Mar 1, 2017 · 12 comments
Closed

py3 get rid of last call to cmp() in parent.pyx #22484

fchapoton opened this issue Mar 1, 2017 · 12 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@fchapoton
Copy link
Contributor

as a step to python3

replace a strange use of _cmp_ in a Parent class by a more standard method __richcmp__

CC: @tscrim @jdemeyer @a-andre

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 3bbd8bb

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/22484
@fchapoton fchapoton added this to the sage-7.6 milestone Mar 1, 2017
@fchapoton
Copy link
Contributor Author

Commit: 6d91790

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22484

@fchapoton
Copy link
Contributor Author

New commits:

6d91790py3 try to get rid of last calls to cmp() in parent.pyx

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 1, 2017

Changed commit from 6d91790 to 78d8568

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 1, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

78d8568trac 22484 fixing a detail

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@jdemeyer
Copy link

jdemeyer commented Mar 1, 2017

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Mar 1, 2017

Changed branch from u/chapoton/22484 to u/jdemeyer/22484

@jdemeyer
Copy link

jdemeyer commented Mar 1, 2017

Changed commit from 78d8568 to 3bbd8bb

@jdemeyer
Copy link

jdemeyer commented Mar 1, 2017

comment:6

Same functionality with more efficient code.

New commits:

3bbd8bbMore efficient Set_PythonType.__richcmp__

@fchapoton
Copy link
Contributor Author

comment:7

ok, green bot, looks good to me. You can set a positive review if you want.

@vbraun
Copy link
Member

vbraun commented Mar 3, 2017

Changed branch from u/jdemeyer/22484 to 3bbd8bb

@vbraun vbraun closed this as completed in 5dff1a4 Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton