Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document git trac try #22504

Closed
paulmasson mannequin opened this issue Mar 2, 2017 · 17 comments
Closed

Document git trac try #22504

paulmasson mannequin opened this issue Mar 2, 2017 · 17 comments

Comments

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Mar 2, 2017

This is taken mostly verbatim from git-trac-command's README.md at
https://github.com/sagemath/git-trac-command

Component: documentation

Author: Paul Masson

Branch/Commit: 01d06c7

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/22504

@paulmasson paulmasson mannequin added this to the sage-7.6 milestone Mar 2, 2017
@paulmasson

This comment has been minimized.

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Mar 3, 2017

Branch: u/paulmasson/22504

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Mar 3, 2017

New commits:

764b83cAdd git trac try

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Mar 3, 2017

Commit: 764b83c

@paulmasson paulmasson mannequin added the s: needs review label Mar 3, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

4376fa7Additional comments

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2017

Changed commit from 764b83c to 4376fa7

@dkrenn
Copy link
Contributor

dkrenn commented Mar 9, 2017

comment:5
+ If you want to edit the ticket branch (that is, add additional commits) you cannot
+ use ``git trac try``. You must use ``git trac checkout`` to get the actual ticket
+ branch as a starting point.

We could mention the new section introduced in #22451 to say something on how to continue working on an existing ticket.

@dkrenn
Copy link
Contributor

dkrenn commented Mar 9, 2017

comment:6

Maybe: Should it be stated somewhere, what git trac try actually does in terms of the usual git commands? (Maybe, mentioning that it is similar to git pull could suffice.)

@dkrenn
Copy link
Contributor

dkrenn commented Mar 9, 2017

Reviewer: Daniel Krenn

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

988734dMerge branch '22504' into 22504-1
01d06c7Edit and add links

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2017

Changed commit from 4376fa7 to 01d06c7

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Mar 14, 2017

comment:9

Replying to @dkrenn:

Maybe: Should it be stated somewhere, what git trac try actually does in terms of the usual git commands? (Maybe, mentioning that it is similar to git pull could suffice.)

It already states explicitly that the command creates a merge, not a pull. Isn't that clear enough?

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Mar 14, 2017

comment:10

Replying to @dkrenn:

+ If you want to edit the ticket branch (that is, add additional commits) you cannot
+ use ``git trac try``. You must use ``git trac checkout`` to get the actual ticket
+ branch as a starting point.

We could mention the new section introduced in #22451 to say something on how to continue working on an existing ticket.

This section of the manual appears at the very end and is solely about reviewing tickets. I'd rather not complicate the review process by explaining too much about other operations. To that end, I've replaced git trac checkout here with a link to the appropriate section above in the manual. Since #22451 is now in the current beta, I've also added a link to it in the section of this manual on merging. More appropriate there than here because there is already some information on updating Sage to its most current version.

@dkrenn
Copy link
Contributor

dkrenn commented Mar 14, 2017

comment:11

Replying to @paulmasson:

Replying to @dkrenn:

Maybe: Should it be stated somewhere, what git trac try actually does in terms of the usual git commands? (Maybe, mentioning that it is similar to git pull could suffice.)

It already states explicitly that the command creates a merge, not a pull. Isn't that clear enough?

Ok, I've reread the whole section, and it fits as it is now.

@dkrenn
Copy link
Contributor

dkrenn commented Mar 14, 2017

comment:12

Replying to @paulmasson:

Replying to @dkrenn:

+ If you want to edit the ticket branch (that is, add additional commits) you cannot
+ use ``git trac try``. You must use ``git trac checkout`` to get the actual ticket
+ branch as a starting point.

We could mention the new section introduced in #22451 to say something on how to continue working on an existing ticket.

This section of the manual appears at the very end and is solely about reviewing tickets. I'd rather not complicate the review process by explaining too much about other operations. To that end, I've replaced git trac checkout here with a link to the appropriate section above in the manual. Since #22451 is now in the current beta, I've also added a link to it in the section of this manual on merging. More appropriate there than here because there is already some information on updating Sage to its most current version.

Fair enough.

@slel

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Mar 27, 2017

Changed branch from u/paulmasson/22504 to 01d06c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants