Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade polymake to version 3.1 #22513

Closed
mo271 opened this issue Mar 4, 2017 · 30 comments
Closed

Upgrade polymake to version 3.1 #22513

mo271 opened this issue Mar 4, 2017 · 30 comments

Comments

@mo271
Copy link
Contributor

mo271 commented Mar 4, 2017

With my configuration, the configure script of polymake 3.0 is not working, probably due to a new version of perl:

$ ./configure 
checking C++ compiler ... ok (g++ is GCC 6.3.0)
checking C++ library ... ok (GNU stdlibc++ 20170218, C++ 201402)
determining architecture ... Undefined subroutine &Polymake::Configure::platform_name called at support/configure.pl line 538.

Let's package the latest version of polymake, 3.1.

To build it for Sage do:

Depends on #22606

CC: @videlec @mkoeppe

Component: packages: experimental

Keywords: days84, polymake

Author: Moritz Firsching, Matthias Koeppe

Branch/Commit: 9f0c6d5

Reviewer: Matthias Koeppe, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/22513

@mo271 mo271 added this to the sage-7.6 milestone Mar 4, 2017
@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

Branch: u/moritz/polymake-beta

@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

comment:2

The tar ball, which should be put in the folder upstream can be found here: http://page.mi.fu-berlin.de/moritz/pkgs/polymake-3.1-beta2.tar.bz2

@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

Changed branch from u/moritz/polymake-beta to none

@mkoeppe
Copy link
Member

mkoeppe commented Mar 5, 2017

comment:3

Before you deleted the branch, I pulled it and built successfully on Mac OS.

@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

Branch: u/moritz/polymake-beta

@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

New commits:

d86b8ffinstall of beta 3.1-beta2 now works

@mo271
Copy link
Contributor Author

mo271 commented Mar 5, 2017

Commit: d86b8ff

@mo271

This comment has been minimized.

@mo271

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Mar 5, 2017

Reviewer: Matthias Koeppe

@videlec
Copy link
Contributor

videlec commented Mar 5, 2017

comment:8

This package completely breaks pypolymake. Don't you want to make a different package?

@videlec
Copy link
Contributor

videlec commented Mar 5, 2017

comment:9

Moreover, it is not nice to package yourself upstream. I pushed Moritz to make this package for testing purposes. I am very much against its inclusion in Sage.

@mkoeppe
Copy link
Member

mkoeppe commented Mar 5, 2017

comment:10

OK, I agree

@mkoeppe
Copy link
Member

mkoeppe commented Mar 5, 2017

comment:11

Also, the Singular build seems to fail with this beta version of polymake installed.

@videlec
Copy link
Contributor

videlec commented Mar 7, 2017

comment:12

Replying to @mkoeppe:

Also, the Singular build seems to fail with this beta version of polymake installed.

For the record, this can be fixed with

diff --git a/build/pkgs/singular/spkg-install b/build/pkgs/singular/spkg-install
index 373bd0852b..b172b0ec1f 100755
--- a/build/pkgs/singular/spkg-install
+++ b/build/pkgs/singular/spkg-install
@@ -93,6 +93,7 @@ config()
                 --with-ntl="$SAGE_LOCAL" \
                 --with-flint="$SAGE_LOCAL" \
                 --enable-gfanlib \
+                --disable-polymake \
                 --enable-Singular \
                 --enable-factory \
                 --disable-doc \

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

comment:13

(this fix to Singular is #22606.)

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

Dependencies: #22606

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

comment:15

This new version also breaks #22683. Apparently polymake has changed its mind about some important properties:

    TypeError: initial check failed: dimension mismatch between LINEALITY_SPACE and CONE_AMBIENT_DIM

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

comment:16

Polymake 3.1 was just released. We should repurpose this ticket for the upgrade.

Vincent -- objections to upgrading (if it builds OK) even if pypolymake is not ready yet for that version?

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title package polymake beta Upgrade polymake to version 3.1 Mar 28, 2017
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-7.6, sage-8.0 Mar 28, 2017
@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

comment:19

A possible upstream issue:
Polymake 3.1: Empty polytope has dimension 1

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2017

Changed branch from u/moritz/polymake-beta to u/mkoeppe/polymake-beta

@mkoeppe
Copy link
Member

mkoeppe commented Mar 29, 2017

Changed commit from d86b8ff to 9f0c6d5

@mkoeppe
Copy link
Member

mkoeppe commented Mar 29, 2017

comment:21

Replying to @mkoeppe:

A possible upstream issue:
Polymake 3.1: Empty polytope has dimension 1

It was easy to work around this in #22658.


New commits:

12e7d1cinstall of beta 3.1-beta2 now works
9f0c6d5Upgrade polymake to version 3.1

@mkoeppe
Copy link
Member

mkoeppe commented Mar 29, 2017

Changed author from Moritz Firsching to Moritz Firsching, Matthias Koeppe

@videlec
Copy link
Contributor

videlec commented Mar 29, 2017

comment:23

Simon worked well: all tests of the interface (#22452) pass with this new version of polymake!

@videlec
Copy link
Contributor

videlec commented Mar 29, 2017

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Mar 29, 2017

comment:24

(hopefully the beta branch of pypolymake should be close to be working with polymake 3.1)

@vbraun
Copy link
Member

vbraun commented Mar 30, 2017

Changed branch from u/mkoeppe/polymake-beta to 9f0c6d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants