Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert six.iteritems in laurent_polynomial.pyx #22530

Closed
jdemeyer opened this issue Mar 6, 2017 · 7 comments
Closed

Revert six.iteritems in laurent_polynomial.pyx #22530

jdemeyer opened this issue Mar 6, 2017 · 7 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Mar 6, 2017

Revert

commit 92699fd23f29568077c577b65a1c561b7415269a
Author: Daniel Krenn <git@danielkrenn.at>
Date:   Thu Nov 10 14:40:28 2016 +0100

    Python3-ify (iteritems)

diff --git a/src/sage/rings/polynomial/laurent_polynomial.pyx b/src/sage/rings/polynomial/laurent_polynomial.pyx
index fa61705..e6db620 100644
--- a/src/sage/rings/polynomial/laurent_polynomial.pyx
+++ b/src/sage/rings/polynomial/laurent_polynomial.pyx
@@ -10,6 +10,7 @@ Elements of Laurent polynomial rings
 #                  http://www.gnu.org/licenses/
 #*****************************************************************************
 from __future__ import print_function
+from six import iterkeys, iteritems
 
 from sage.rings.integer cimport Integer
 from sage.structure.element import is_Element, coerce_binop
@@ -2482,11 +2483,11 @@ cdef class LaurentPolynomial_mpair(LaurentPolynomial_generic):
         except ValueError:
             # call _derivative() recursively on coefficients
             return P({m: c._derivative(var)
-                      for (m, c) in self.dict().iteritems()})
+                      for (m, c) in iteritems(self.dict())})
 
         # compute formal derivative with respect to generator
         d = {}
-        for m, c in self.dict().iteritems():
+        for m, c in iteritems(self.dict()):
             if m[index] != 0:
                 new_m = [u for u in m]
                 new_m[index] += -1

Cython understands dict.iteritems() and actually optimizes it (unlike six.iteritems)

CC: @dkrenn

Component: cython

Branch/Commit: u/jdemeyer/revert_six_iteritems_in_laurent_polynomial_pyx @ 1fc5c7b

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/22530

@jdemeyer jdemeyer added this to the sage-7.6 milestone Mar 6, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Mar 6, 2017

@jdemeyer
Copy link
Author

jdemeyer commented Mar 6, 2017

New commits:

1fc5c7bRevert "Python3-ify (iteritems)"

@jdemeyer
Copy link
Author

jdemeyer commented Mar 6, 2017

Commit: 1fc5c7b

@fchapoton
Copy link
Contributor

comment:4

see #22515

@jdemeyer
Copy link
Author

jdemeyer commented Mar 7, 2017

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented Mar 7, 2017

Changed author from Jeroen Demeyer to none

@jdemeyer jdemeyer removed this from the sage-7.6 milestone Mar 7, 2017
@jdemeyer jdemeyer closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants