Deprecate the old .field() method from polyhedron class

[jplab]

Ticket #11634 made the ppl library be the default backend for the Polyhedron class.

Currently, Polyhedron objects still have a .field() method which is ill-named and since #11634 out-dated.

This ticket deprecates this method.

CC: @mo271 @mkoeppe @videlec @sagetrac-tmonteil @fchapoton

Component: geometry

Keywords: days84

Author: Jean-Philippe Labbé

Branch/Commit: 6291dd1

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/22551

[jplab]

Branch: u/jipilab/deprecate_field

[jplab]

New commits:

1e26fe9

Deprecate old keyword and method field

[jplab]

Commit: 1e26fe9

[videlec]

Changed branch from u/jipilab/deprecate_field to none

[videlec]

Changed commit from 1e26fe9 to none

[videlec]

comment:3

In cdd_convert you need to test the deprecation

[videlec]

New commits:

1e26fe9

Deprecate old keyword and method field

[videlec]

Branch: u/jipilab/deprecate_field

[videlec]

Commit: 1e26fe9

[videlec]

comment:5

@@ -2032,8 +2032,6 @@ class Polyhedron_base(Element):
         """
         return self.parent().base_ring()
 
-    field = base_ring
-
     @cached_method
     def center(self):

No deprecation here?

[videlec]

Reviewer: Vincent Delecroix

[jplab]

comment:7

Replying to @videlec:

@@ -2032,8 +2032,6 @@ class Polyhedron_base(Element):
         """
         return self.parent().base_ring()
 
-    field = base_ring
-
     @cached_method
     def center(self):

No deprecation here?

Hmm. Right. I confused the keyword with the method here. I will add a deprecation warning.

[jplab]

comment:8

Replying to @videlec:

In cdd_convert you need to test the deprecation

Since it is in a nested function, I removed the deprecation warning.

This was intended merely to make the nomenclature about base ring consistent across the geometry component...

[sagetrac-git]

Changed commit from 1e26fe9 to 6291dd1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6291dd1

Added and removed deprecation warnings

[videlec]

comment:11

I can not reproduce the timeout from the patchbot.

[vbraun]

Changed branch from u/jipilab/deprecate_field to 6291dd1