Write custom create_extension() for Cython

[jdemeyer]

Implement a custom create_extension() function for Cython. This new function does some things which were done in setup.py in different places, but now have one dedicated place. It should also fix the problem where -std=c99 is used for a C++ extension, which is an error for Clang. Also duplicate flags (like -msse -mmse) are removed.

This requires an upstream patch cython/cython#466

Upstream: Fixed upstream, but not in a stable release.

Component: build

Author: Jeroen Demeyer

Branch/Commit: 0c0c603

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/22554

[jdemeyer]

Branch: u/jdemeyer/use_create_extension___from_cython

[sagetrac-git]

Commit: 4446cb4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4446cb4

Write custom create_extension() for Cython

[sagetrac-git]

Changed commit from 4446cb4 to 47452a3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

47452a3

Write custom create_extension() for Cython

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f59e4e1

Write custom create_extension() for Cython

[sagetrac-git]

Changed commit from 47452a3 to f59e4e1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0c0c603

Write custom create_extension() for Cython

[sagetrac-git]

Changed commit from f59e4e1 to 0c0c603

[mkoeppe]

comment:11

I can't really comment on this patch, but I've successfully built sage with it on my Mac with homebrew (which provides gfortran, so the Sage gcc is not installed), using Apple's "gcc" (clang)

[jdemeyer]

comment:12

Replying to @mkoeppe:

I can't really comment on this patch, but I've successfully built sage with it on my Mac with homebrew (which provides gfortran, so the Sage gcc is not installed), using Apple's "gcc" (clang)

Just to be clear: I assume you mean with SAGE_INSTALL_GCC=no, otherwise Sage will build and use GCC anyway.

[mkoeppe]

comment:13

Turns out I used a different "feature" of the build system. I had configured using ./configure CC=gcc-6 CXX=g++-6 (they are from homebrew) and then configure was happy; but then the build just used /usr/bin/gcc anyway. (This bug is #22646.)

[jdemeyer]

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.

[dimpase]

comment:15

What does "This requires an upstream patch" mean? That it should be applied to the upstream tarball?

(in fact one does not seem to need it to be applied to Sage, so this probably needs to be clarified in the ticket description)

[jdemeyer]

comment:16

Replying to @dimpase:

What does "This requires an upstream patch" mean?

That the patch from the linked github pull request should be applied to the Cython sources. In this case, the patch is added as build/pkgs/cython/patches/create_extension.patch and the Cython version number is bumped to force rebuilding Cython with that patch.

[dimpase]

Reviewer: Dima Pasechnik

[vbraun]

Changed branch from u/jdemeyer/use_create_extension___from_cython to 0c0c603