Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rst2ipynb doctest failures #22585

Closed
jdemeyer opened this issue Mar 11, 2017 · 10 comments
Closed

rst2ipynb doctest failures #22585

jdemeyer opened this issue Mar 11, 2017 · 10 comments
Labels
p: blocker / 1 t: bug t: tests
Milestone
sage-7.6

Comments

@jdemeyer
Copy link

The nbformat version number is hardcoded in some tests, don't do that.

Component: doctest coverage

Author: Jeroen Demeyer

Branch: d6e61fe

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22585
@jdemeyer jdemeyer added this to the sage-7.6 milestone Mar 11, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/rst2ipynb_doctest_failures

@jdemeyer
Copy link
Author

New commits:

d6e61feDo not hardcode nbformat version number in tests

@jdemeyer
Copy link
Author

Commit: d6e61fe

@fchapoton
Copy link
Contributor

Reviewer: Fréderic Chapoton

@fchapoton
Copy link
Contributor

comment:5

lgtm

@vbraun
Copy link
Member

vbraun commented Mar 15, 2017

Changed branch from u/jdemeyer/rst2ipynb_doctest_failures to d6e61fe

@vbraun vbraun closed this as completed in d07c220 Mar 15, 2017
@jdemeyer
Copy link
Author

Changed commit from d6e61fe to none

@jdemeyer
Copy link
Author

Changed reviewer from Fréderic Chapoton to Frédéric Chapoton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: blocker / 1 t: bug t: tests
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton