Upgrade cysignals

[jdemeyer]

Tarball: https://github.com/sagemath/cysignals/releases/download/1.6.3/cysignals-1.6.3.tar.bz2

CC: @vbraun

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: f11f773

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/22695

[jdemeyer]

Changed dependencies from #22584 to none

[jdemeyer]

Branch: u/jdemeyer/upgrade_cysignals

[jdemeyer]

Commit: dc9e509

[jdemeyer]

New commits:

dc9e509

Upgrade to cysignals version 1.5.0

[sagetrac-git]

Changed commit from dc9e509 to b7772d9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b7772d9

Upgrade to cysignals version 1.6.0

[jdemeyer]

comment:11

Doctest failure in src/sage/repl/ipython_kernel/kernel.py

[sagetrac-git]

Changed commit from b7772d9 to 3f0fc37

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3f0fc37

Fix doctest for cysignals upgrade

[jdemeyer]

comment:14

Passes all doctests.

[vbraun]

Reviewer: Volker Braun

[vbraun]

comment:16

Debug build fails with

[cysignals-1.6.0]     gcc -fno-strict-aliasing -g -O2 -g -O0 -Wall -Wno-unused -fPIC -Isrc/cysignals -Ibuild/src -Ibuild/src/cysignals -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/python2.7 -c build/src/cysignals/signals.c -o build/temp.linux-x86_64-2.7-pydebug/build/src/cysignals/signals.o
[cysignals-1.6.0]     In file included from build/src/cysignals/signals.c:460:0:
[cysignals-1.6.0]     build/src/cysignals/macros.h: In function 'sig_block':
[cysignals-1.6.0]     build/src/cysignals/macros.h:243:9: warning: implicit declaration of function 'print_backtrace' [-Wimplicit-function-declaration]
[cysignals-1.6.0]              print_backtrace();
[cysignals-1.6.0]              ^~~~~~~~~~~~~~~
[cysignals-1.6.0]     In file included from build/src/cysignals/signals.c:463:0:
[cysignals-1.6.0]     build/src/cysignals/implementation.c: At top level:
[cysignals-1.6.0]     build/src/cysignals/implementation.c:72:13: warning: conflicting types for 'print_backtrace'
[cysignals-1.6.0]      static void print_backtrace(void);
[cysignals-1.6.0]                  ^~~~~~~~~~~~~~~
[cysignals-1.6.0]     build/src/cysignals/implementation.c:72:13: error: static declaration of 'print_backtrace' follows non-static declaration
[cysignals-1.6.0]     In file included from build/src/cysignals/signals.c:460:0:
[cysignals-1.6.0]     build/src/cysignals/macros.h:243:9: note: previous implicit declaration of 'print_backtrace' was here
[cysignals-1.6.0]              print_backtrace();
[cysignals-1.6.0]              ^~~~~~~~~~~~~~~
[cysignals-1.6.0]     error: command 'gcc' failed with exit status 1
[cysignals-1.6.0]     Running setup.py install for cysignals: finished with status 'error'

[sagetrac-git]

Changed commit from 3f0fc37 to 8c05957

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f2bcabd	Upgrade to cysignals version 1.6.3
8c05957	Fix doctest for cysignals upgrade

[jdemeyer]

comment:19

Fixed in 1.6.3

[vbraun]

comment:20

The tests don't work:

[cysignals-1.6.3] creating build/temp.macosx-10.9-x86_64-2.7
[cysignals-1.6.3] gcc -fno-strict-aliasing -I/Users/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/python2-2.7.13.p0/include -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -I/Users/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/cysignals-1.6.3/src/tmp/user/lib/python2.7/site-packages/cysignals -I/Users/buildslave-sage/slave/sage_git/build/local/include/python2.7 -c cysignals_example.cpp -o build/temp.macosx-10.9-x86_64-2.7/cysignals_example.o
[cysignals-1.6.3] cysignals_example.cpp:470:28: fatal error: struct_signals.h: No such file or directory
[cysignals-1.6.3] compilation terminated.
[cysignals-1.6.3] error: command 'gcc' failed with exit status 1
[cysignals-1.6.3] make[3]: *** [check-prefix-example] Error 1
[cysignals-1.6.3] src/cysignals/pselect.pyx
[cysignals-1.6.3] src/cysignals/pysignals.pyx
[cysignals-1.6.3] src/cysignals/signals.pyx
[cysignals-1.6.3] src/cysignals/tests.pyx
[cysignals-1.6.3] make[3]: Target `check' not remade because of errors.
[cysignals-1.6.3] 
[cysignals-1.6.3] real	0m35.818s
[cysignals-1.6.3] user	0m29.127s
[cysignals-1.6.3] sys	0m0.960s
[cysignals-1.6.3] ************************************************************************
[cysignals-1.6.3] Error testing package cysignals-1.6.3
[cysignals-1.6.3] ************************************************************************

[jdemeyer]

comment:21

I cannot reproduce that on Linux. Are you using some unusual compiler or environment variables?

I'll test it on your OSX machine now.

[jdemeyer]

comment:22

Got it. It's a race condition with parallel builds.

Thanks for the report.

[sagetrac-git]

Changed commit from 8c05957 to f11f773

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f11f773

Run "check-install" (to check installed version of cysignals)

[jdemeyer]

comment:25

Fixed in two ways:

1. Instead of doing make check (which does a temporary installation), we run make check-install in Sage, which checks the installed version of cysignals.

2. The race condition with make check is fixed upstream.

[vbraun]

Changed branch from u/jdemeyer/upgrade_cysignals to f11f773