Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest: bug with first call to ex.series() #22733

Closed
rwst opened this issue Apr 1, 2017 · 13 comments
Closed

Doctest: bug with first call to ex.series() #22733

rwst opened this issue Apr 1, 2017 · 13 comments

Comments

@rwst
Copy link

rwst commented Apr 1, 2017

In a fresh Sage:

sage: var('a b c c0 c1 c2 c3 c4 c5 c6 d i j m n p r k u x y z')
(a, b, c, c0, c1, c2, c3, c4, c5, c6, d, i, j, m, n, p, r, k, u, x, y, z)
sage: a.series(x)
1*x + Order(x^20)
sage: b.series(x)
(b)

sage: var('z0 z')
(z0, z)
sage: z0.series(x)
1*x + Order(x^20)
sage: z.series(x)
(z)

sage: var('z0 z')
(z0, z)
sage: z.series(x)
1*x + Order(x^20)
sage: z0.series(x)
(z0)

It seems to always affect the first call to series.

Depends on #23134

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 92e6f44

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22733

@rwst rwst added this to the sage-8.0 milestone Apr 1, 2017
@rwst
Copy link
Author

rwst commented May 17, 2017

Dependencies: pynac-0.7.8

@rwst
Copy link
Author

rwst commented May 17, 2017

Upstream: Fixed upstream, in a later stable release.

@rwst
Copy link
Author

rwst commented May 25, 2017

comment:2

See also #23072

@rwst
Copy link
Author

rwst commented Jun 3, 2017

Changed dependencies from pynac-0.7.8 to #23134

@rwst
Copy link
Author

rwst commented Jun 3, 2017

Changed upstream from Fixed upstream, in a later stable release. to none

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2017

comment:4

Just add a doctest, and I will set a positive review.

@rwst
Copy link
Author

rwst commented Jun 4, 2017

@rwst
Copy link
Author

rwst commented Jun 4, 2017

comment:6

Note: The failure is dependent on memory content and changes with every change of the comment part of the code. So, while this is fixed and the test always passes the test might not fail in versions that have the bug reintroduced.


New commits:

92e6f4422733: Doctest: Bug with first call to ex.series()

@rwst
Copy link
Author

rwst commented Jun 4, 2017

Commit: 92e6f44

@rwst
Copy link
Author

rwst commented Jun 4, 2017

Author: Ralf Stephan

@rwst rwst changed the title Bug with first call to ex.series() Doctest: bug with first call to ex.series() Jun 4, 2017
@tscrim
Copy link
Collaborator

tscrim commented Jun 4, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 4, 2017

comment:7

It's hard to have tests that are guaranteed to fail if a bug was (re)introduced, so we will just have to do the best we can.

@vbraun
Copy link
Member

vbraun commented Jun 22, 2017

Changed branch from u/rws/bug_with_first_call_to_ex_series__ to 92e6f44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants