New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LatticePoset: "antidoubling", part 3 #22745
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Ready for review. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Martin? This is quite direct implementation. Long note in the decription is not needed for review. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:6
I got an answer from Tristan Holmes. There are lattices that have congruence lattice having both maximal chains satisfying and not satisfying the needed property. Hence the code can not be easily optimized. (There is room for optimization -- not all congruences are always needed to compute -- but that's a different story.) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Travis, can you look at this? (I think that after this, maybe in July, I want to make a code for doing the decomposition. Not sure if it should be a |
comment:9
One little this: - if e_up not in reachable:
- if splitting_depth_2(e, e_up):
+ if e_up not in reachable and splitting_depth_2(e, e_up): Otherwise LGTM. |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
|
comment:12
Thanks. |
Changed branch from u/jmantysalo/latticeposet___antidoubling___part_3 to |
This patch adds a function to recognize if a lattice can be constructed by Day doubling constructions of any (possible) subsets. (Also adds "interface" for #22693.) The code may be unoptimal. For those who want to think:
CC: @mantepse @tscrim
Component: combinatorics
Author: Jori Mäntysalo
Branch/Commit:
13abce1
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/22745
The text was updated successfully, but these errors were encountered: