Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatticePoset: "antidoubling", part 3 #22745

Closed
jm58660 mannequin opened this issue Apr 3, 2017 · 21 comments
Closed

LatticePoset: "antidoubling", part 3 #22745

jm58660 mannequin opened this issue Apr 3, 2017 · 21 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 3, 2017

This patch adds a function to recognize if a lattice can be constructed by Day doubling constructions of any (possible) subsets. (Also adds "interface" for #22693.) The code may be unoptimal. For those who want to think:

CC: @mantepse @tscrim

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: 13abce1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22745

@jm58660 jm58660 mannequin added this to the sage-8.0 milestone Apr 3, 2017
@jm58660 jm58660 mannequin added c: combinatorics labels Apr 3, 2017
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 25, 2017

@jm58660

This comment has been minimized.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 25, 2017

comment:2

Ready for review.


New commits:

8c4a3dfAdd more tests for being doubling constructible.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 25, 2017

Commit: 8c4a3df

@jm58660 jm58660 mannequin added the s: needs review label Apr 25, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

48fb811Merge branch 'develop' into t/22745/latticeposet___antidoubling___part_3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2017

Changed commit from 8c4a3df to 48fb811

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 5, 2017

comment:4

Martin? This is quite direct implementation.

Long note in the decription is not needed for review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

87d58c2Add a test.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2017

Changed commit from 48fb811 to 87d58c2

@jm58660

This comment has been minimized.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 5, 2017

comment:6

I got an answer from Tristan Holmes. There are lattices that have congruence lattice having both maximal chains satisfying and not satisfying the needed property. Hence the code can not be easily optimized.

(There is room for optimization -- not all congruences are always needed to compute -- but that's a different story.)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2017

Changed commit from 87d58c2 to 74af0fe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

74af0feMerge branch 'develop' into t/22745/latticeposet___antidoubling___part_3

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 15, 2017

comment:8

Travis, can you look at this?

(I think that after this, maybe in July, I want to make a code for doing the decomposition. Not sure if it should be a certificate for this or another function. Anyways, congruence-related functions are almost done now.)

@tscrim
Copy link
Collaborator

tscrim commented May 15, 2017

comment:9

One little this:

-                if e_up not in reachable:
-                    if splitting_depth_2(e, e_up):
+                if e_up not in reachable and splitting_depth_2(e, e_up):

Otherwise LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 15, 2017

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

13abce1From if-if to if-and.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2017

Changed commit from 74af0fe to 13abce1

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 15, 2017

comment:11

If ...: ... if changed to if ... and ...:.

@tscrim
Copy link
Collaborator

tscrim commented May 15, 2017

comment:12

Thanks.

@vbraun
Copy link
Member

vbraun commented May 16, 2017

Changed branch from u/jmantysalo/latticeposet___antidoubling___part_3 to 13abce1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants