Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order and chain polytopes are defined over ZZ #22754

Closed
fchapoton opened this issue Apr 4, 2017 · 14 comments
Closed

order and chain polytopes are defined over ZZ #22754

fchapoton opened this issue Apr 4, 2017 · 14 comments

Comments

@fchapoton
Copy link
Contributor

Currently, order_polytope and chain_polytope of posets return polytopes over QQ. They can be enhanced to return polytopes over ZZ.

This allows to compute their Ehrhart polynomial, for example.

CC: @jplab @jm58660 @tscrim

Component: combinatorics

Keywords: polytope

Author: Frédéric Chapoton

Branch/Commit: 9fe4db4

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/22754

@fchapoton fchapoton added this to the sage-8.0 milestone Apr 4, 2017
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22754

@fchapoton
Copy link
Contributor Author

Commit: 6e42715

@fchapoton
Copy link
Contributor Author

New commits:

07d53b5py3: wrap some "map" with "list"
6e42715posets: order and chain polytopes over ZZ

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9aeefb1posets: order and chain polytopes over ZZ

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2017

Changed commit from 6e42715 to 9aeefb1

@jplab
Copy link

jplab commented Apr 4, 2017

comment:3

Indeed, they are.

The patch looks fine to me.

@jplab
Copy link

jplab commented Apr 4, 2017

comment:4

There is only one thing: the polyhedron are given with the H-representation... but indeed, the vertices are integers in the end...

So I guess it is good to go...

@vbraun
Copy link
Member

vbraun commented Apr 7, 2017

comment:5

Reviewer name...

@jplab
Copy link

jplab commented Apr 7, 2017

Reviewer: Jean-Philippe Labbé

@vbraun
Copy link
Member

vbraun commented Apr 9, 2017

comment:7

See patchbot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

1efb4bdMerge branch 'u/chapoton/22754' in 8.0.b1
9fe4db4trac 22754 fixing one doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2017

Changed commit from 9aeefb1 to 9fe4db4

@fchapoton
Copy link
Contributor Author

comment:9

trivial doctest correction done, setting back to positive

@vbraun
Copy link
Member

vbraun commented Apr 11, 2017

Changed branch from u/chapoton/22754 to 9fe4db4

@vbraun vbraun closed this as completed in 53df02f Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants