Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic limit #22844

Closed
rwst opened this issue Apr 20, 2017 · 20 comments
Closed

Symbolic limit #22844

rwst opened this issue Apr 20, 2017 · 20 comments

Comments

@rwst
Copy link

rwst commented Apr 20, 2017

Equivalently to #21645 a symbolic limit function is needed, in this case #20179 supposes that expressions can be searched for unexpanded limit functions which is not possible if it is anonymous.

CC: @EmmanuelCharpentier

Component: symbolics

Author: Ralf Stephan

Branch/Commit: ce95d01

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22844

@rwst rwst added this to the sage-8.0 milestone Apr 20, 2017
@rwst
Copy link
Author

rwst commented Apr 25, 2017

Branch: u/rws/symbolic_limit

@rwst
Copy link
Author

rwst commented Apr 25, 2017

Commit: 2f5a28f

@rwst
Copy link
Author

rwst commented Apr 25, 2017

Author: Ralf Stephan

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2017

Changed commit from 2f5a28f to bd403fd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

bd403fd22844:internal symbolic limit function

@rwst
Copy link
Author

rwst commented May 2, 2017

comment:5

Doctest failures in src/sage/calculus/calculus.py.

@rwst
Copy link
Author

rwst commented May 4, 2017

comment:6

The latex conversion would be easily fixed. However, the fails show that there is the problem that the limit function can have either 3 or 4 arguments, the latter with an additional direction. I don't think Sage can handle this at the moment without tuples as arguments like in hypergeometric, and this would change the code substantially.

EDIT: it may be possible to use two functions; checks elsewhere would then have to be done with both. The Maxima interface would have to know about it.

@rwst
Copy link
Author

rwst commented May 4, 2017

comment:7

Maybe it is excusable in this case to write a customized __call__ member, as long as it's an internally only used function.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

38e6441Merge branch 'develop' into t/22844/symbolic_limit
bd0a22622844: latex conversion, direction arg, interface cleanup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2017

Changed commit from bd403fd to bd0a226

@rwst
Copy link
Author

rwst commented May 4, 2017

comment:9

Much easier: nargs=0 does the trick. Please review.

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2017

comment:10

Needs a rebase over the latest develop.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2017

Changed commit from bd0a226 to 14f2647

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

14f2647Merge branch 'develop' into t/22844/symbolic_limit

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

ce95d01Merge branch 'develop' into t/22844/symbolic_limit

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2017

Changed commit from 14f2647 to ce95d01

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2017

comment:13

LGTM.

@rwst
Copy link
Author

rwst commented May 15, 2017

comment:14

Thanks.

@vbraun
Copy link
Member

vbraun commented May 15, 2017

Changed branch from u/rws/symbolic_limit to ce95d01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants