Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: replace StringTypes by six.string_types #22876

Closed
fchapoton opened this issue Apr 26, 2017 · 6 comments
Closed

py3: replace StringTypes by six.string_types #22876

fchapoton opened this issue Apr 26, 2017 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

for python3 compatibility

CC: @tscrim @jm58660 @jdemeyer @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 37e80c2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22876
@fchapoton fchapoton added this to the sage-8.0 milestone Apr 26, 2017
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22876

@fchapoton
Copy link
Contributor Author

New commits:

37e80c2py3: do not use StringTypes but six.string_types

@fchapoton
Copy link
Contributor Author

Commit: 37e80c2

@tscrim
Copy link
Collaborator

tscrim commented Apr 26, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 26, 2017

comment:2

LGTM.

@vbraun
Copy link
Member

vbraun commented Apr 28, 2017

Changed branch from u/chapoton/22876 to 37e80c2

@vbraun vbraun closed this as completed in 4d91c17 Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton