Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade numpy to 1.12.1 #22895

Closed
dimpase opened this issue Apr 28, 2017 · 14 comments
Closed

upgrade numpy to 1.12.1 #22895

dimpase opened this issue Apr 28, 2017 · 14 comments
Labels
c: packages: standard r: wontfix t: enhancement

Comments

@dimpase
Copy link
Member

dimpase commented Apr 28, 2017

this removes one of our patches, has more vectorisation, and in view of work on #22799 it's better to work with the latest release, to be in sync with numpy devs.

the tarball is here - more precisely it's a zip file.

CC: @kiwifb @jdemeyer

Component: packages: standard

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22895
@dimpase dimpase added this to the sage-8.0 milestone Apr 28, 2017
@dimpase
Copy link
Member Author

dimpase commented Apr 28, 2017

comment:1

a branch is coming in a minute

@dimpase

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member Author

dimpase commented Apr 28, 2017

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Apr 28, 2017

Commit: 010214a

@dimpase
Copy link
Member Author

dimpase commented Apr 28, 2017

New commits:

010214aupdate to version 1.12.1

@dimpase
Copy link
Member Author

dimpase commented Apr 28, 2017

Branch: u/dimpase/numpy1121

@jhpalmieri
Copy link
Member

comment:4

The upgrade to numpy is included as part of #22582, which is already positively reviewed. So I propose to close this as a duplicate.

@tscrim
Copy link
Collaborator

tscrim commented Apr 29, 2017

Changed author from Dima Pasechnik to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 29, 2017

Changed branch from u/dimpase/numpy1121 to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 29, 2017

comment:5

I concur.

@tscrim
Copy link
Collaborator

tscrim commented Apr 29, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 29, 2017

Changed commit from 010214a to none

@tscrim tscrim removed this from the sage-8.0 milestone Apr 29, 2017
@dimpase
Copy link
Member Author

dimpase commented Apr 30, 2017

comment:6

sure, no problem --- finding out that #22582 does a numpy update wasn't really possible.

@embray
Copy link
Contributor

embray commented Jul 13, 2017

comment:7

Closing tickets in the sage-duplicate/invalid/wontfix module with positive_review (i.e. someone has confirmed they should be closed).

@embray embray closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard r: wontfix t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@embray @dimpase @tscrim @jhpalmieri