Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cython interface to Pynac's find_function #22925

Closed
rwst opened this issue May 2, 2017 · 7 comments
Closed

Fix Cython interface to Pynac's find_function #22925

rwst opened this issue May 2, 2017 · 7 comments
Labels
c: interfaces p: minor / 4 t: bug
Milestone
sage-8.0

Comments

@rwst
Copy link

rwst commented May 2, 2017

There is ancient code in pynac.pxd that causes failures with Pynac dev versions. Especially the construct except +ValueError doesn't work as apparently assumed.

Component: interfaces

Author: Ralf Stephan

Branch/Commit: 143f133

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22925
@rwst rwst added this to the sage-8.0 milestone May 2, 2017
@rwst
Copy link
Author

rwst commented May 2, 2017

Branch: u/rws/fix_cython_interface_to_pynac_s_find_function

@rwst
Copy link
Author

rwst commented May 2, 2017

New commits:

143f13322925: Fix Cython interface to Pynac's find_function

@rwst
Copy link
Author

rwst commented May 2, 2017

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented May 2, 2017

Commit: 143f133

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 8, 2017

Changed branch from u/rws/fix_cython_interface_to_pynac_s_find_function to 143f133

@vbraun vbraun closed this as completed in c2e84e2 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: minor / 4 t: bug
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @rwst @tscrim