Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to #22666 #22929

Closed
embray opened this issue May 2, 2017 · 11 comments
Closed

Followup to #22666 #22929

embray opened this issue May 2, 2017 · 11 comments
Labels
c: porting: cygwin c: python3 p: blocker / 1 t: bug
Milestone
sage-8.0

Comments

@embray
Copy link
Contributor

embray commented May 2, 2017

The Python 3 build is still broken in Cygwin since #22666. I mistakenly removed a patch that was still needed after all (or rather, I stripped away part of a patch that was still needed).

Depends on #22666

Component: porting: Cygwin

Keywords: windows cygwin python3

Author: Erik Bray

Branch/Commit: 9f553cd

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22929
@embray embray added this to the sage-8.0 milestone May 2, 2017
@embray
Copy link
Contributor Author

embray commented May 2, 2017

Dependencies: u/embray/cygwin/python3-build-2

@embray
Copy link
Contributor Author

embray commented May 2, 2017

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented May 2, 2017

Branch: #22666

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Commit: 9f553cd

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Changed branch from #22666 to u/embray/cygwin/python3-build-2

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Changed dependencies from u/embray/cygwin/python3-build-2 to #22666

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

New commits:

9f553cdFix this patch, which was incorrectly changed in https://github.com/sagemath/sage/issues/22666

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

comment:3

LGTM. Thanks.

@embray
Copy link
Contributor Author

embray commented May 5, 2017

comment:4

This is actually a blocker.

@vbraun
Copy link
Member

vbraun commented May 8, 2017

Changed branch from u/embray/cygwin/python3-build-2 to 9f553cd

@vbraun vbraun closed this as completed in 2603c91 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting: cygwin c: python3 p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@embray @vbraun @tscrim