Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken install of Python 2 and 3 on Cygwin since #22764 #22930

Closed
embray opened this issue May 2, 2017 · 8 comments
Closed

Fixed broken install of Python 2 and 3 on Cygwin since #22764 #22930

embray opened this issue May 2, 2017 · 8 comments
Labels
c: porting: cygwin p: blocker / 1 t: bug
Milestone
sage-8.0

Comments

@embray
Copy link
Contributor

embray commented May 2, 2017

#22764 did not update the bits added by #20437 to reflect the removal of the "python" symlink.

In the process of investigating this I also realized I did not create the symlink for Python 3 correctly in the first place (but this was not noticed since we don't currently link anything against the Python 3 libpython during a normal Sage build).

CC: @tscrim

Component: porting: Cygwin

Keywords: python cygwin windows

Author: Erik Bray

Branch/Commit: 217a9da

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22930
@embray embray added this to the sage-8.0 milestone May 2, 2017
@embray
Copy link
Contributor Author

embray commented May 2, 2017

Commit: 217a9da

@embray
Copy link
Contributor Author

embray commented May 2, 2017

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented May 2, 2017

Branch: u/embray/cygwin/python-install-2

@embray
Copy link
Contributor Author

embray commented May 2, 2017

New commits:

217a9daFix linking to the import library for libpython on Python 2 and 3

@embray
Copy link
Contributor Author

embray commented May 2, 2017

Changed keywords from none to python cygwin windows

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

comment:3

LGTM. Thanks.

@tscrim
Copy link
Collaborator

tscrim commented May 2, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 4, 2017

Changed branch from u/embray/cygwin/python-install-2 to 217a9da

@vbraun vbraun closed this as completed in 2204f76 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting: cygwin p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@embray @vbraun @tscrim