clean up deprecations in sandpile

[dimpase]

Some deprecation in sandpile are in fact already removed, but still present in lazy imports. This breaks ups vars() and locals().

Namely, these are grid_sandpile and complete_sandpile.

In fact, we should clean up everything that was deprecated in #18618.

However, we leave sandlib in the code, only remove it from the global namespace, as e.g. sandlib('gor') does not have an equivalent.

Also, it turns out that while calling vars() directly still fails, one now can at least do

v=vars()
for k in v.keys(): print v[k]

Depends on #22582

CC: @jhpalmieri @sagetrac-dperkinson

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: 81e8959

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/22933

[dimpase]

Branch: u/dimpase/spfix

[dimpase]

Author: Dima Pasechnik

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

dc46ea2	trac 22582: fix merge conflicts
bc4c2f5	trac 22582: rename build/bin/sage-python to sage-python23
0d30e20	trac 22582: use sage-python23 to build the Sage library
7e7b5bc	trac 22582: build and test packages using sage-python23 instead of python
b954864	trac 22582: no need to make python2 a dependency for python3
2dad104	trac 22582: a little documentation
5a645fd	Merge branch 'public/22582' of trac.sagemath.org:sage into t/22582/public/22582
2179ac8	Merge branch 8.0.beta3 into t/22582/public/22582
6d54e12	Merge remote-tracking branch 'trac/public/22582' into spfix
d4b7838	removed lazy_imports with deprecations

[sagetrac-git]

Commit: d4b7838

[jhpalmieri]

comment:4

Why is random_digraph no longer deprecated? (I know nothing about the sandpiles code, just wondering.)

[jhpalmieri]

comment:5

There are several other places where you are removing deprecation warnings without removing the (previously) deprecated functions.

[dimpase]

comment:6

Replying to @jhpalmieri:

There are several other places where you are removing deprecation warnings without removing the (previously) deprecated functions.

Deprecated was placing them into the global namespace. These functions are still used internally in the module.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f86a910	removed previously deprecated firing_vector and random_digraph
81e8959	fix a typo in a message

[sagetrac-git]

Changed commit from d4b7838 to 81e8959

[dimpase]

comment:8

OK, I've removed two removable deprecated functions.

[jhpalmieri]

comment:10

This is not an issue that we should deal with on this ticket, but according to the deprecation notices, someone should move the functionality from sandlib to the catalog of examples accessible using sandpiles.

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:11

I'm happy with the changes here.

[vbraun]

Changed branch from u/dimpase/spfix to 81e8959