New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_of_hecke_algebra does not do what the docstring and function arguments suggests #22967
Milestone
Comments
New commits:
|
Changed keywords from none to modular abelian variety, hecke algebra |
Author: Kevin Lui |
Commit: |
This comment has been minimized.
This comment has been minimized.
Changed keywords from modular abelian variety, hecke algebra to modular abelian variety, hecke algebra, sd87 |
Reviewer: Gerardo Zelaya |
comment:4
The new input describes accurately the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method image_of_hecke_algebra computes the image by starting with the zero subspace and adding hecke operators until the sturm bound.
This patch speeds up this method significantly by checking at each step whether the current module is the full endomorphism ring by checking to see if it is of maximal rank and is saturated. This method is already referenced in the current code but was never actually implemented.
The speedup should be evident in most modular abelian varieties of dimension greater than 1.
Without the break condition:
With the break condition:
I also checked this is against the old code. I broke the caching by commenting out lines 956-959 and then ran this code on a big computer.
Component: modular forms
Keywords: modular abelian variety, hecke algebra, sd87
Author: Kevin Lui
Branch/Commit:
af8fbd2
Reviewer: Gerardo Zelaya
Issue created by migration from https://trac.sagemath.org/ticket/22967
The text was updated successfully, but these errors were encountered: