Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: get rid of cmp in coerce.pyx #22980

Closed
fchapoton opened this issue May 11, 2017 · 9 comments
Closed

py3: get rid of cmp in coerce.pyx #22980

fchapoton opened this issue May 11, 2017 · 9 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

To make this file cythonize correctly with python3

removes the next-to-last call to cmp in pyx files

CC: @tscrim @jdemeyer @jhpalmieri @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 8952815

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22980
@fchapoton fchapoton added this to the sage-8.0 milestone May 11, 2017
@fchapoton
Copy link
Contributor Author

Commit: 8952815

@fchapoton
Copy link
Contributor Author

New commits:

8952815py3 : get rid of cmp in coerce.pyx

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22980

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:2

ok, bot is essentially green (up to a doctest related to the annoying ticket #22833)

please review !

@tscrim
Copy link
Collaborator

tscrim commented May 11, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 11, 2017

comment:3

LGTM.

@fchapoton
Copy link
Contributor Author

comment:4

Thanks ! Last call to cmp() in .pyx files is dealed with in #22981 !

@vbraun
Copy link
Member

vbraun commented May 14, 2017

Changed branch from u/chapoton/22980 to 8952815

@vbraun vbraun closed this as completed in 106fab3 May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton