New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement is_NaN for all rings with NaN elements #23001
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Ralf Stephan |
comment:5
LGTM. |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:8
Thanks. Oops, I had some additions after your comments. |
comment:9
No problem, they were easy enough to recheck. |
Changed branch from u/rws/implement_is_nan_for_all_rings_with_nan_elements to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Elements of the following rings can't be checked for
NaN
:CC
(RR
can)CDF
(RDF
can)CIF
(RIF
can)Other rings don't have
NaN
so there is no need for them.The ticket might add back-conversions from complex NaN to real NaN (which should always be possible).
Component: numerical
Author: Ralf Stephan
Branch/Commit:
920e5ad
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/23001
The text was updated successfully, but these errors were encountered: