Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement is_NaN for all rings with NaN elements #23001

Closed
rwst opened this issue May 15, 2017 · 13 comments
Closed

Implement is_NaN for all rings with NaN elements #23001

rwst opened this issue May 15, 2017 · 13 comments

Comments

@rwst
Copy link

rwst commented May 15, 2017

Elements of the following rings can't be checked for NaN:

  • CC (RR can)
  • CDF (RDF can)
  • CIF (RIF can)
  • Ball fields

Other rings don't have NaN so there is no need for them.

The ticket might add back-conversions from complex NaN to real NaN (which should always be possible).

Component: numerical

Author: Ralf Stephan

Branch/Commit: 920e5ad

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23001

@rwst rwst added this to the sage-8.0 milestone May 15, 2017
@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented May 15, 2017

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

ca839ea23001: is_NaN for ball fields
5f8b70323001: NaN back-conversion with interval fields

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2017

Commit: 5f8b703

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented May 16, 2017

Author: Ralf Stephan

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2017

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2017

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2017

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

920e5ad23001: Back-convert complex NaN (NaN+NaN*I) to the resp. real field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2017

Changed commit from 5f8b703 to 920e5ad

@rwst
Copy link
Author

rwst commented May 16, 2017

comment:8

Thanks. Oops, I had some additions after your comments.

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2017

comment:9

No problem, they were easy enough to recheck.

@vbraun
Copy link
Member

vbraun commented May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants