Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Parent.construction to the Sets.ParentMethods, and categorify three more parents #23010

Closed
nthiery opened this issue May 16, 2017 · 15 comments
Closed

Move Parent.construction to the Sets.ParentMethods, and categorify three more parents #23010

nthiery opened this issue May 16, 2017 · 15 comments
Labels
c: categories r: duplicate t: enhancement

Comments

@nthiery
Copy link
Contributor

nthiery commented May 16, 2017

Moving the default implementation Parent.construction (which just
returns None) to Sets.ParentMethods enables categories to provide an
implementation when relevant.

This ticket also fixes QuaternionAlgebra, QuaternionOrder,
LazyPowerSeriesRing and MPCComplexField whose categories were not
properly initialized (and as a consequence they did not inherit
anymore the construction method)

See also: #21380

CC: @tscrim @simon-king-jena

Component: categories

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23010
@nthiery nthiery added this to the sage-8.0 milestone May 16, 2017
@nthiery
Copy link
Contributor Author

nthiery commented May 16, 2017

Branch: u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents

@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented May 16, 2017

Commit: 1a13892

@nthiery
Copy link
Contributor Author

nthiery commented May 16, 2017

New commits:

acd9af323010: Lift Parent.construction to Sets.ParentMethods
fe1a0c223010: categorification of QuaternionAlgebra and QuaternionOrder
27f756f23010: Categorification of MPCComplexField
1a1389223010: Categorification of LazyPowerSeriesRing

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2017

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 20, 2017

comment:4

Docs dont build

@mkoeppe mkoeppe modified the milestones: sage-8.0, sage-9.2 Aug 17, 2020
@fchapoton
Copy link
Contributor

Changed commit from 1a13892 to 99aa8ad

@fchapoton
Copy link
Contributor

comment:6

too bad to let this bit-rot just because of a documentation problem.

New commits:

99aa8adMerge branch 'u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents' in 9.2.beta8

@fchapoton
Copy link
Contributor

Changed branch from u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents to public/ticket/23010

@mkoeppe
Copy link
Member

mkoeppe commented Sep 3, 2020

comment:7

These commits seem to have been merged already through other tickets. Nothing left to be done.

@mkoeppe mkoeppe removed this from the sage-9.2 milestone Sep 3, 2020
@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2020

Changed branch from public/ticket/23010 to none

@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2020

Changed commit from 99aa8ad to none

@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2020

comment:8

Yes, indeed.

@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2020

Changed author from Nicolas M. Thiéry to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: categories r: duplicate t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nthiery @vbraun @tscrim @fchapoton @mkoeppe