Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

givaro does not pass self-tests on 32bit systems #23056

Closed
sagetrac-tmonteil mannequin opened this issue May 22, 2017 · 14 comments
Closed

givaro does not pass self-tests on 32bit systems #23056

sagetrac-tmonteil mannequin opened this issue May 22, 2017 · 14 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 22, 2017

See the attached build log givaro-4.0.2.p0.log and the corresponding failing test suite test-suite.log.

Depends on #24214

Upstream: Reported upstream. Developers acknowledge bug.

CC: @ClementPernet

Component: packages: standard

Keywords: sdl

Issue created by migration from https://trac.sagemath.org/ticket/23056

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-8.0 milestone May 22, 2017
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 22, 2017

Attachment: givaro-4.0.2.p0.log

Attachment: test-suite.log

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 22, 2017

Upstream: Reported upstream. No feedback yet.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 22, 2017

comment:2

In case, the difference between 94499109968480 and 94499109902944 is 2^16.

@ClementPernet
Copy link
Contributor

comment:3

This was linbox-team/givaro#39 which I had erroneously closed, as it did not show up for while.
I reopened the issue. Note that on our CI build, the difference is 2^13 x 13, 2^15 or 5x2^14.

@ClementPernet
Copy link
Contributor

comment:4

Note that the field that causes this bug ModularExtended<double> is not being used in sage.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 23, 2017

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 25, 2017

comment:6

Replying to @ClementPernet:

Note that the field that causes this bug ModularExtended<double> is not being used in sage.

Thanks for the hint, let me remove the blocker priority. But i guess it is still healthy to provide upstream packages well-tested and with their whole capabilities (also, we might use that field later in Sage).

@ClementPernet
Copy link
Contributor

Dependencies: #24214

@ClementPernet
Copy link
Contributor

comment:7

fixed in #24214

@fchapoton
Copy link
Contributor

comment:8

is this fixed now ? should we close this ticket ?

@fchapoton fchapoton removed this from the sage-8.0 milestone Jun 26, 2018
@ClementPernet
Copy link
Contributor

comment:9

I confirm that this ticket can be closed. Sorry for having forgotten to close when #24214 was fixed.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 26, 2018

comment:10

I confirm that givaro 4.0.4 builds and pass self-tests on my 23bit VM.

@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:11

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Aug 27, 2019

Changed keywords from none to sdl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants