Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: get rid of cmp in complex interval field #23060

Closed
fchapoton opened this issue May 23, 2017 · 14 comments
Closed

py3: get rid of cmp in complex interval field #23060

fchapoton opened this issue May 23, 2017 · 14 comments

Comments

@fchapoton
Copy link
Contributor

a tiny ticket, on our long way to python3

CC: @tscrim @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: d67aef5

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/23060

@fchapoton fchapoton added this to the sage-8.0 milestone May 23, 2017
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23600

@fchapoton
Copy link
Contributor Author

Commit: f960e2e

@fchapoton
Copy link
Contributor Author

New commits:

f960e2eget rid of cmp and `__cmp__` in complex interval fields

@fchapoton
Copy link
Contributor Author

comment:2

green bot, should be an easy review

@jhpalmieri
Copy link
Member

Changed branch from u/chapoton/23600 to u/jhpalmieri/23600

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:4

I edited a few docstrings. If this is okay, feel free to set to a positive review.


New commits:

30e69edtrac 23060: docstring editing

@jhpalmieri
Copy link
Member

Changed commit from f960e2e to 30e69ed

@fchapoton
Copy link
Contributor Author

comment:5

humm, it should really be unequality (meaning !=) and not inequality (meaning <= !

EDIT: but I am not a native of Shakespeare's country..

@jhpalmieri
Copy link
Member

comment:6

I don't think "unequality" is a word, but here is a modified version.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d67aef5trac 23060: docstring editing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2017

Changed commit from 30e69ed to d67aef5

@fchapoton
Copy link
Contributor Author

comment:8

Thanks. I think I have used "unequality" a few times now, and that will need clean-up elsewhere.

Setting to positive.

@vbraun
Copy link
Member

vbraun commented May 27, 2017

Changed branch from u/jhpalmieri/23600 to d67aef5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants