Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using cysignals .pxi files (part 1) #23094

Closed
jdemeyer opened this issue May 29, 2017 · 7 comments
Closed

Stop using cysignals .pxi files (part 1) #23094

jdemeyer opened this issue May 29, 2017 · 7 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

Follow-up to #22806 and #22896: we should stop using the deprecated files cysignals/memory.pxi and cysignals/signals.pxi.

Given the large number of files which need to be changed, this is done in parts.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 3a18fbe

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/23094
@jdemeyer jdemeyer added this to the sage-8.0 milestone May 29, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/stop_using_cysignals__pxi_files__part_1_

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 29, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3a18fbeStop using cysignals .pxi files (part 1)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 29, 2017

Commit: 3a18fbe

@jdemeyer

This comment has been minimized.

Sign in to view
@seblabbe
Copy link
Contributor

comment:5

On Ubuntu 16.04, make ptestlong finishes with All tests passed!.

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@vbraun
Copy link
Member

vbraun commented May 31, 2017

Changed branch from u/jdemeyer/stop_using_cysignals__pxi_files__part_1_ to 3a18fbe

@vbraun vbraun closed this as completed in 1916fd7 May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @seblabbe @jdemeyer