Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowness with unramified extensions of Qp #23172

Open
xcaruso opened this issue Jun 7, 2017 · 18 comments
Open

Slowness with unramified extensions of Qp #23172

xcaruso opened this issue Jun 7, 2017 · 18 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Jun 7, 2017

I noticed that the methods residue and _div_ are ridiculously slow over Zq(p^n, prec) when prec is very large.

Note: the original purpose of the ticket seems to have been resolved due to improvements to expansion method.

Component: padics

Keywords: sd87, padicIMA, padicBordeaux

Author: Vishal Arul

Branch/Commit: u/roed/residue_speed @ f4cb405

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/23172

@xcaruso xcaruso added this to the sage-8.0 milestone Jun 7, 2017
@roed314
Copy link
Contributor

roed314 commented Jul 17, 2017

Changed keywords from none to sd87

@roed314
Copy link
Contributor

roed314 commented Jul 22, 2018

Changed keywords from sd87 to sd87, padicIMA

@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

Branch: u/roed/residue_speed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8ad3281Add test for residue

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Commit: 8ad3281

@sagetrac-varul
Copy link
Mannequin

sagetrac-varul mannequin commented Jul 23, 2018

Changed branch from u/roed/residue_speed to u/varul/residue_speed

@sagetrac-varul

This comment has been minimized.

@sagetrac-varul
Copy link
Mannequin

sagetrac-varul mannequin commented Jul 23, 2018

New commits:

15c3eb0Made residue function faster

@sagetrac-varul
Copy link
Mannequin

sagetrac-varul mannequin commented Jul 23, 2018

Changed commit from 8ad3281 to 15c3eb0

@sagetrac-varul
Copy link
Mannequin

sagetrac-varul mannequin commented Jul 25, 2018

Author: varul

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 25, 2018

Reviewer: Xavier Caruso

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 25, 2018

comment:8

Looks good to me.

Positive review if the patchbot is happy.

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 25, 2018

Changed author from varul to Vishal Arul

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 25, 2018

comment:9

Patchbot says:

sage -t --long src/sage/rings/padics/padic_base_leaves.py  # 12 doctests failed
sage -t --long src/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py  # 37 doctests failed
sage -t --long src/sage/rings/padics/padic_extension_leaves.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/padic_valuation.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/local_generic.py  # 3 doctests failed
sage -t --long src/sage/rings/padics/padic_ZZ_pX_CR_element.pyx  # 5 doctests failed
sage -t --long src/sage/rings/valuation/gauss_valuation.py  # 1 doctest failed
sage -t --long src/sage/rings/padics/padic_generic.py  # 1 doctest failed

@roed314
Copy link
Contributor

roed314 commented Sep 7, 2019

Changed keywords from sd87, padicIMA to sd87, padicIMA, padicBordeaux

@roed314
Copy link
Contributor

roed314 commented Sep 9, 2019

Changed branch from u/varul/residue_speed to u/roed/residue_speed

@roed314
Copy link
Contributor

roed314 commented Sep 9, 2019

comment:13

I just merged in 8.9.beta9


New commits:

f4cb405Merge branch 'u/varul/residue_speed' of git://trac.sagemath.org/sage into 23172_residue_speed

@roed314
Copy link
Contributor

roed314 commented Sep 9, 2019

Changed commit from 15c3eb0 to f4cb405

@mkoeppe mkoeppe removed this from the sage-8.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants