Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache is_squarefree() for polynomials #23182

Closed
saraedum opened this issue Jun 8, 2017 · 12 comments
Closed

Cache is_squarefree() for polynomials #23182

saraedum opened this issue Jun 8, 2017 · 12 comments

Comments

@saraedum
Copy link
Member

saraedum commented Jun 8, 2017

Just like is_irreducible(), but that method is only implemented in a single place.

Depends on #23164

Component: commutative algebra

Keywords: sd86.5

Author: Julian Rüth

Branch/Commit: 580a8e4

Reviewer: Nils Bruin

Issue created by migration from https://trac.sagemath.org/ticket/23182

@saraedum

This comment has been minimized.

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

Dependencies: #23164

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

Author: Julian Rüth

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

9c2a4e3Added line to polynomial_element.pyx to allow caching and added doctests for cached methods.
9d9e878Fix doctest error in sage/structure/misc.pyx
ffad85cMerge branch 'u/roed/cache_polynomial_is_irreducible__' of git://trac.sagemath.org/sage into t/23164/cache_polynomial_is_irreducible__

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2017

Commit: ffad85c

@nbruin
Copy link
Contributor

nbruin commented Jun 9, 2017

Reviewer: Nils Bruin

@vbraun
Copy link
Member

vbraun commented Jun 14, 2017

comment:5

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 16, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

580a8e4Merge branch 'develop' into t/23182/cache_polynomial_is_irreducible__

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 16, 2017

Changed commit from ffad85c to 580a8e4

@saraedum
Copy link
Member Author

comment:7

A doctest has been added in the same spot twice. Trivial merge conflict, so I am setting this back to positive review.


New commits:

580a8e4Merge branch 'develop' into t/23182/cache_polynomial_is_irreducible__

@vbraun
Copy link
Member

vbraun commented Jun 17, 2017

Changed branch from u/saraedum/cache_polynomial_is_irreducible__ to 580a8e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants