New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using cysignals .pxi files in interpreters #23195
Comments
Dependencies: #23196 |
Commit: |
comment:4
I don't really know enough about the differences between the old and new APIs to really have an opinion about this, but it seems obvious and straightforward enough. |
comment:5
Replying to @embray:
The main goal here is getting rid of the of Cython The change from (*) They would like to deprecate |
Reviewer: Travis Scrimshaw |
comment:6
LGTM. |
Changed dependencies from #23196 to none |
comment:7
This doesn't strictly depend on #23196. |
Dependencies: #23196 |
comment:8
Actually, it does depend since this branch contains the commit from #23196. |
Changed branch from u/jdemeyer/stop_using_cysignals__pxi_files_in_interpreters to |
Follow-up to #22806 and #22896: we should stop using the deprecated files
cysignals/memory.pxi
andcysignals/signals.pxi
.This deals with the auto-generated interpreters files. Besides changing the include to a cimport, we also clean up and optimize the memory allocation code a bit.
Depends on #23196
CC: @embray
Component: cython
Author: Jeroen Demeyer
Branch/Commit:
be167ac
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/23195
The text was updated successfully, but these errors were encountered: