Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using cysignals .pxi files in interpreters #23195

Closed
jdemeyer opened this issue Jun 9, 2017 · 13 comments
Closed

Stop using cysignals .pxi files in interpreters #23195

jdemeyer opened this issue Jun 9, 2017 · 13 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 9, 2017

Follow-up to #22806 and #22896: we should stop using the deprecated files cysignals/memory.pxi and cysignals/signals.pxi.

This deals with the auto-generated interpreters files. Besides changing the include to a cimport, we also clean up and optimize the memory allocation code a bit.

Depends on #23196

CC: @embray

Component: cython

Author: Jeroen Demeyer

Branch/Commit: be167ac

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23195

@jdemeyer jdemeyer added this to the sage-8.0 milestone Jun 9, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Jun 9, 2017

Dependencies: #23196

@jdemeyer
Copy link
Author

jdemeyer commented Jun 9, 2017

@jdemeyer
Copy link
Author

jdemeyer commented Jun 9, 2017

Commit: be167ac

@jdemeyer
Copy link
Author

jdemeyer commented Jun 9, 2017

New commits:

78abaaeFix doctest parsing with triple quotes inside parentheses
be167acStop using cysignals .pxi files in interpreters

@embray
Copy link
Contributor

embray commented Jun 9, 2017

comment:4

I don't really know enough about the differences between the old and new APIs to really have an opinion about this, but it seems obvious and straightforward enough.

@jdemeyer
Copy link
Author

jdemeyer commented Jun 9, 2017

comment:5

Replying to @embray:

I don't really know enough about the differences between the old and new APIs

The main goal here is getting rid of the of Cython include statements, which are semi-deprecated(*) by Cython upstream.

The change from sig_malloc to check_allocarray is just a minor clean-up which removes the need for the NULL check.

(*) They would like to deprecate include statements. However, there are some corner cases where include statements make sense, so they don't formally deprecate them. Instead, they just keep them working in the current state, rejecting any new features.

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2017

comment:6

LGTM.

@jdemeyer
Copy link
Author

Changed dependencies from #23196 to none

@jdemeyer
Copy link
Author

comment:7

This doesn't strictly depend on #23196.

@jdemeyer
Copy link
Author

Dependencies: #23196

@jdemeyer
Copy link
Author

comment:8

Actually, it does depend since this branch contains the commit from #23196.

@vbraun
Copy link
Member

vbraun commented Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants