Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require surjectivity to be implemented for composite injectivity #23205

Closed
saraedum opened this issue Jun 10, 2017 · 6 comments
Closed

Comments

@saraedum
Copy link
Member

Currently, this fails even though all morphisms are known to be injective.

sage: QQ.hom(QQbar)*ZZ.hom(QQ)

Composite map:
  From: Integer Ring
  To:   Algebraic Field
  Defn:   Ring Coercion morphism:
          From: Integer Ring
          To:   Rational Field
        then
          Ring Coercion morphism:
          From: Rational Field
          To:   Algebraic Field
sage: _.is_injective()

Component: commutative algebra

Keywords: sd86.5

Author: Julian Rüth

Branch/Commit: b21c370

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23205

@saraedum
Copy link
Member Author

@saraedum
Copy link
Member Author

New commits:

b21c370Do not require is_surjective/is_injective to be implemented on as many morphisms to decide injectivity/surjectivity of composite maps

@saraedum
Copy link
Member Author

Commit: b21c370

@roed314
Copy link
Contributor

roed314 commented Jun 10, 2017

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Jun 10, 2017

comment:3

All tests pass; looks good.

@vbraun
Copy link
Member

vbraun commented Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants