Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cryptominisat an optional package #23219

Closed
sagetrac-tmonteil mannequin opened this issue Jun 11, 2017 · 8 comments
Closed

Make cryptominisat an optional package #23219

sagetrac-tmonteil mannequin opened this issue Jun 11, 2017 · 8 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Jun 11, 2017

Cryptominisat was experimental since it did break Sage on 32bit architecture (see #19781). This has been fixed by #22817 and #22818, so let us make it optional again.

Depends on #22818

CC: @seblabbe

Component: packages: optional

Keywords: sdl

Author: Thierry Monteil

Branch/Commit: b223033

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23219

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-8.0 milestone Jun 11, 2017
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 11, 2017

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 11, 2017

Commit: b223033

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 11, 2017

Last 10 new commits:

be9db62#22818 : move documentation of INPUT from `__init__` to the class, as suggested in [comment:34](#comment%3A34).
0566102#22818 : pass options from SAT to CruptoMiniSat.
e382251#22818 : remove useless import.
5236281#22818 : comment 40.
6ed1c73Merge branch 't/22818/interface_cryptominisat_5' into t/22817/package_cryptominisat_5
9593ce6Merge
c9dd355 #22818 : comment 55.
c22de1d#22818 : comment 59.
ce47403Merge branch 'u/tmonteil/interface_cryptominisat_5' of trac.sagemath.org:sage into HEAD
b223033#23219 : make cryptominisat an optional package.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 11, 2017

Author: Thierry Monteil

@tscrim
Copy link
Collaborator

tscrim commented Jun 11, 2017

comment:4

Agreed.

@tscrim
Copy link
Collaborator

tscrim commented Jun 11, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 13, 2017

Changed branch from u/tmonteil/make_cryptominisat_an_optional_package to b223033

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Aug 27, 2019

Changed keywords from none to sdl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants