Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: change in cmp for homset and ring morphisms #23239

Closed
fchapoton opened this issue Jun 14, 2017 · 11 comments
Closed

py3: change in cmp for homset and ring morphisms #23239

fchapoton opened this issue Jun 14, 2017 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

as another step to py3

  • transform __cmp__ in homset to just __eq__ and __ne__

  • change comparison of ring morphisms not to do <, >, <=, >= anymore

CC: @tscrim @jdemeyer @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 1d19536

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23239
@fchapoton fchapoton added this to the sage-8.0 milestone Jun 14, 2017
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23239

@fchapoton
Copy link
Contributor Author

New commits:

3ed480dpy3: no cmp in homset.py

@fchapoton
Copy link
Contributor Author

Commit: 3ed480d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2017

Changed commit from 3ed480d to 1d19536

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

1d19536trac 23239 simplify comparison of ring morphisms

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@fchapoton fchapoton changed the title py3: get rid of __cmp__ and cmp in homset.py py3: change in cmp for homset and ring morphisms Jun 15, 2017
@fchapoton

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Jun 16, 2017

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 16, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 17, 2017

Changed branch from u/chapoton/23239 to 1d19536

@vbraun vbraun closed this as completed in b807c21 Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton