Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: get rid of cmp for formal groups of elliptic curves #23285

Closed
fchapoton opened this issue Jun 20, 2017 · 10 comments
Closed

py3: get rid of cmp for formal groups of elliptic curves #23285

fchapoton opened this issue Jun 20, 2017 · 10 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

as another micro-step to py3

also cleans the doc a little bit in the changed file

CC: @JohnCremona @jdemeyer @tscrim @categorie @roed314

Component: python3

Author: Frédéric Chapoton

Branch/Commit: b9fafe9

Reviewer: Chris Wuthrich

Issue created by migration from https://trac.sagemath.org/ticket/23285
@fchapoton fchapoton added this to the sage-8.0 milestone Jun 20, 2017
@fchapoton
Copy link
Contributor Author

New commits:

0669975py3: get rid of cmp for formal groups of elliptic curves

@fchapoton
Copy link
Contributor Author

Commit: 0669975

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23285

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

b9fafe9trac 23285 typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2017

Changed commit from 0669975 to b9fafe9

@chriswuthrich
Copy link
Contributor

comment:4

All changes very good, but I have not tested.

@fchapoton
Copy link
Contributor Author

comment:5

green bot. Ready for a positive review ?

@chriswuthrich
Copy link
Contributor

Reviewer: Chris Wuthrich

@chriswuthrich
Copy link
Contributor

comment:6

yop. doc also looks better.

@vbraun
Copy link
Member

vbraun commented Jun 22, 2017

Changed branch from u/chapoton/23285 to b9fafe9

@vbraun vbraun closed this as completed in 5b5e6a5 Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @chriswuthrich