Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: some care for cmp in some modular files #23301

Closed
fchapoton opened this issue Jun 22, 2017 · 11 comments
Closed

py3: some care for cmp in some modular files #23301

fchapoton opened this issue Jun 22, 2017 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

namely lseries, congroup (very partial cure) and smoothchar

CC: @tscrim @jdemeyer @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 76b8ae5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23301
@fchapoton fchapoton added this to the sage-8.0 milestone Jun 22, 2017
@fchapoton
Copy link
Contributor Author

New commits:

d0bdb05py3: some care for cmp in modular (lseries, congroup, smoothchar)

@fchapoton
Copy link
Contributor Author

Commit: d0bdb05

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23301

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

76b8ae5trac 23310 better eq

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2017

Changed commit from d0bdb05 to 76b8ae5

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton fchapoton changed the title py3: some care fore cmp in some modular files py3: some care for cmp in some modular files Jun 22, 2017
@fchapoton
Copy link
Contributor Author

comment:4

let us wait for a patchbot report

@fchapoton
Copy link
Contributor Author

comment:5

bot is morally green

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2017

comment:6

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 25, 2017

Changed branch from u/chapoton/23301 to 76b8ae5

@vbraun vbraun closed this as completed in a467d23 Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton