Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change Singular includes #23306

Closed
jdemeyer opened this issue Jun 22, 2017 · 6 comments
Closed

Do not change Singular includes #23306

jdemeyer opened this issue Jun 22, 2017 · 6 comments
Labels
c: packages: standard p: minor / 4 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

The fix_includes step in the Singular installer is no longer needed now that we have pkgconfig.

CC: @kiwifb @infinity0

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: f025937

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/23306
@jdemeyer jdemeyer added this to the sage-8.0 milestone Jun 22, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/do_not_change_singular_includes

@jdemeyer
Copy link
Author

New commits:

f025937Do not change Singular includes

@jdemeyer
Copy link
Author

Commit: f025937

@kiwifb
Copy link
Member

kiwifb commented Jun 22, 2017

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Jun 22, 2017

comment:3

Looks good to me. As discussed on sage-packaging.

@vbraun
Copy link
Member

vbraun commented Jun 25, 2017

Changed branch from u/jdemeyer/do_not_change_singular_includes to f025937

@vbraun vbraun closed this as completed in 273a2af Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@kiwifb @vbraun @jdemeyer