Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored exceptions in glpk_backend.pyx #23314

Closed
jdemeyer opened this issue Jun 22, 2017 · 7 comments
Closed

Ignored exceptions in glpk_backend.pyx #23314

jdemeyer opened this issue Jun 22, 2017 · 7 comments
Labels
c: cython p: major / 3 t: bug
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

In the file src/sage/numerical/backends/glpk_backend.pyx, there are two ignored exceptions doctested(!), in get_row_stat and get_col_stat.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 2345e61

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23314
@jdemeyer jdemeyer added this to the sage-8.0 milestone Jun 22, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ignored_exceptions_in_glpk_backend_pyx

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

Commit: 2345e61

@jdemeyer
Copy link
Author

New commits:

2345e61Fix ignored exceptions in glpk_backend.pyx

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2017

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 25, 2017

Changed branch from u/jdemeyer/ignored_exceptions_in_glpk_backend_pyx to 2345e61

@vbraun vbraun closed this as completed in 52fb56e Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer