Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to the implementation of Fomin's growth diagrams #23319

Closed
mantepse opened this issue Jun 23, 2017 · 156 comments
Closed

Various improvements to the implementation of Fomin's growth diagrams #23319

mantepse opened this issue Jun 23, 2017 · 156 comments

Comments

@mantepse
Copy link
Contributor

Implement the backward rule for Sylvester insertion on binary trees, and make the dual graded graphs accessible.

Also allow for multiple edges in the dual graded graphs, implement shifted insertion and affine insertion as examples.

CC: @sagetrac-sage-combinat @tscrim @anneschilling @nthiery @darijgr

Component: combinatorics

Author: Martin Rubey, Travis Scrimshaw

Branch/Commit: 43b6324

Reviewer: Martin Rubey, Travis Scrimshaw, Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/23319

@mantepse mantepse added this to the sage-8.0 milestone Jun 23, 2017
@mantepse
Copy link
Contributor Author

@mantepse
Copy link
Contributor Author

Author: Martin Rubey

@mantepse
Copy link
Contributor Author

Commit: bf1d772

@mantepse
Copy link
Contributor Author

New commits:

bf1d772add backward rule for Sylvester, add access to the graded graphs

@mantepse

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

6c34a9cmicro improvement to the backward rule in GrowthDiagramBinWord
74260a3add support for multiple edges, add class for shifted shapes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Changed commit from bf1d772 to 74260a3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Changed commit from 74260a3 to 2785f3f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

2785f3ffix P_chain and Q_chain for graphs with multiple edges, record disagreement in ShiftedShapes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Changed commit from 2785f3f to 53d37c7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

53d37c7lazy import shifted shapes, fix forward rule, fix tests

@mantepse
Copy link
Contributor Author

comment:7

There are still some missing doctests to make the patchbot happy, which I'll provide in time, but it should be functional.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

e96e3e1fix missing DiGraph import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2017

Changed commit from 53d37c7 to e96e3e1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2017

Changed commit from e96e3e1 to f1ba932

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

f1ba932add backwards rules for shifted shapes

@mantepse

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

5a66779initial version of a class for LLMS insertion

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2017

Changed commit from f1ba932 to 5a66779

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

cc4110calmost done with LLMS insertion

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Changed commit from 5a66779 to cc4110c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Changed commit from cc4110c to 8853225

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

8853225fix a bug and add more (failing) tests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Changed commit from 8853225 to 995d6d6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

995d6d6fix final fehler, produce P_symbol as StrongTableau

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

3ed851bA little bit more of doc polish.

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

Reviewer: Martin Rubey, Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

comment:105

I've done a few more changes and somewhat foregoing comment:87 and comment:90 to have a mix of both ways in the module-level documentation (which is primarily for new users) in the spirit of just completing this. If my changes are good, then go ahead and set this to a positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

c2ed8d3fix a parenthesis, remark on duality, fix _check_duality, add test

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Changed commit from 3ed851b to c2ed8d3

@mantepse
Copy link
Contributor Author

comment:107

I was implementing a pair of dual graphs, and had a bug. To make debugging easier, I made the message in _check_duality better. To do so, I also had to be consistent with "up in P and down in Q". To understand that, I added a remark on duality.

Apart from that, I removed a parenthesis.

If it's OK, please go ahead and set it to positive (finally :-)

If you dislike the more verbose error message, you can remove it, modify it, whatever you like!

@darijgr
Copy link
Contributor

darijgr commented Sep 29, 2017

comment:108

Is the singular in "its predecessor" really intended? As in, there is only one?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Changed commit from c2ed8d3 to 28ddfbe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

28ddfbeno, it's not a tree

@mantepse
Copy link
Contributor Author

comment:110

slightly embarrassed :-)

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

comment:111

One last little typo:

assigning to each vertex the formal sum of its predecessor,

should be predecessors. Once done, you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

Changed reviewer from Martin Rubey, Travis Scrimshaw to Martin Rubey, Travis Scrimshaw, Darij Grinberg

@tscrim tscrim modified the milestones: sage-8.0, sage-8.1 Sep 29, 2017
@mantepse
Copy link
Contributor Author

comment:112

Wonderful!

I have yet another example ready - although without forward and backward rule because I don't know them: Dual graded graphs for (skew) quasisymmetric Schur functions. https://arxiv.org/pdf/1512.04614v1.pdf.

I have the graphs, and the conversion from a saturated chain in the P-graph to a CompositionTableaux.

Could you please confirm that it's better to put this in another ticket?

Or should I push?

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

comment:113

I would say another ticket since this one is big enough already.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Changed commit from 28ddfbe to 43b6324

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

43b6324fix typos, add reference

@mantepse
Copy link
Contributor Author

comment:116

Yippee!

@tscrim
Copy link
Collaborator

tscrim commented Sep 29, 2017

comment:117

Thank you for all of your work on this.

@mantepse
Copy link
Contributor Author

comment:118

Follow up on #23941 :-)

@vbraun
Copy link
Member

vbraun commented Oct 1, 2017

Changed branch from public/combinat/improve_growth_diagrams-23319 to 43b6324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants