New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to the implementation of Fomin's growth diagrams #23319
Comments
Author: Martin Rubey |
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
There are still some missing doctests to make the patchbot happy, which I'll provide in time, but it should be functional. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Martin Rubey, Travis Scrimshaw |
comment:105
I've done a few more changes and somewhat foregoing comment:87 and comment:90 to have a mix of both ways in the module-level documentation (which is primarily for new users) in the spirit of just completing this. If my changes are good, then go ahead and set this to a positive review. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:107
I was implementing a pair of dual graphs, and had a bug. To make debugging easier, I made the message in Apart from that, I removed a parenthesis. If it's OK, please go ahead and set it to positive (finally :-) If you dislike the more verbose error message, you can remove it, modify it, whatever you like! |
comment:108
Is the singular in "its predecessor" really intended? As in, there is only one? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:110
slightly embarrassed :-) |
comment:111
One last little typo:
should be |
Changed reviewer from Martin Rubey, Travis Scrimshaw to Martin Rubey, Travis Scrimshaw, Darij Grinberg |
comment:112
Wonderful! I have yet another example ready - although without forward and backward rule because I don't know them: Dual graded graphs for (skew) quasisymmetric Schur functions. https://arxiv.org/pdf/1512.04614v1.pdf. I have the graphs, and the conversion from a saturated chain in the P-graph to a Could you please confirm that it's better to put this in another ticket? Or should I push? |
comment:113
I would say another ticket since this one is big enough already. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:116
Yippee! |
comment:117
Thank you for all of your work on this. |
comment:118
Follow up on #23941 :-) |
Changed branch from public/combinat/improve_growth_diagrams-23319 to |
Implement the backward rule for Sylvester insertion on binary trees, and make the dual graded graphs accessible.
Also allow for multiple edges in the dual graded graphs, implement shifted insertion and affine insertion as examples.
CC: @sagetrac-sage-combinat @tscrim @anneschilling @nthiery @darijgr
Component: combinatorics
Author: Martin Rubey, Travis Scrimshaw
Branch/Commit:
43b6324
Reviewer: Martin Rubey, Travis Scrimshaw, Darij Grinberg
Issue created by migration from https://trac.sagemath.org/ticket/23319
The text was updated successfully, but these errors were encountered: