New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up matroid constructor #23382
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reviewer: Stefan van Zwam |
comment:7
Clean code, all doctests pass. Nice work! It gets my positive review. |
Changed branch from u/jdemeyer/clean_up_matroid_constructor to |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some basic clean up of the matroid constructor. In particular, use normal variables like
groundset
instead ofkwds['groundset']
. Simplify the code and add more doctests for errors.I'm particularly proud of this:
This is -21 lines despite adding several doctests.
Component: matroid theory
Author: Jeroen Demeyer
Branch/Commit:
23a7260
Reviewer: Stefan van Zwam
Issue created by migration from https://trac.sagemath.org/ticket/23382
The text was updated successfully, but these errors were encountered: