Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up matroid constructor #23382

Closed
jdemeyer opened this issue Jul 6, 2017 · 9 comments
Closed

Clean up matroid constructor #23382

jdemeyer opened this issue Jul 6, 2017 · 9 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jul 6, 2017

Some basic clean up of the matroid constructor. In particular, use normal variables like groundset instead of kwds['groundset']. Simplify the code and add more doctests for errors.

I'm particularly proud of this:

 2 files changed, 235 insertions(+), 256 deletions(-)

This is -21 lines despite adding several doctests.

Component: matroid theory

Author: Jeroen Demeyer

Branch/Commit: 23a7260

Reviewer: Stefan van Zwam

Issue created by migration from https://trac.sagemath.org/ticket/23382

@jdemeyer jdemeyer added this to the sage-8.0 milestone Jul 6, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Jul 6, 2017

@jdemeyer
Copy link
Author

jdemeyer commented Jul 6, 2017

Commit: 23a7260

@jdemeyer
Copy link
Author

jdemeyer commented Jul 6, 2017

New commits:

23a7260Clean up matroid constructor

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Jul 9, 2017

Reviewer: Stefan van Zwam

@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Jul 9, 2017

comment:7

Clean code, all doctests pass. Nice work! It gets my positive review.

@vbraun
Copy link
Member

vbraun commented Jul 26, 2017

Changed branch from u/jdemeyer/clean_up_matroid_constructor to 23a7260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants