Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster conversions from number field to interval field #23447

Open
videlec opened this issue Jul 17, 2017 · 9 comments
Open

faster conversions from number field to interval field #23447

videlec opened this issue Jul 17, 2017 · 9 comments

Comments

@videlec
Copy link
Contributor

videlec commented Jul 17, 2017

The conversion of number field elements to real interval field is slow (that was actually the main reason for the slowness constated in #23388). We implement a function cdef void nf_elem_get_mpfi(mpfi_t x, NumberFieldElement a, mp_prec_t prec) that provides an interval approximation of a number field element. We then refactorize the methods floor() and _richcmp_() and provide a straightforward implementation of _real_mpfi_().

This improves the overall performance of any method of number field element using approximation.

Depends on #23402

Component: number fields

Author: Vincent Delecroix

Branch/Commit: u/vdelecroix/23447 @ 4a40fbe

Issue created by migration from https://trac.sagemath.org/ticket/23447

@videlec videlec added this to the sage-8.1 milestone Jul 17, 2017
@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Jul 17, 2017

Commit: 4a40fbe

@videlec
Copy link
Contributor Author

videlec commented Jul 17, 2017

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Jul 17, 2017

Branch: u/vdelecroix/23447

@videlec
Copy link
Contributor Author

videlec commented Jul 17, 2017

New commits:

0146c8623388: faster floor for nf element
8124ba523402: faster hash for nf elements
4a40fbe23447: faster conversion nf -> rif

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Jul 20, 2017

comment:5

doctest failures...

sage -t --long --warn-long 37.3 src/sage/modular/modform_hecketriangle/hecke_triangle_group_element.py  # 3 doctests failed
sage -t --long --warn-long 37.3 src/sage/schemes/projective/projective_morphism.py  # 4 doctests failed
sage -t --long --warn-long 37.3 src/sage/groups/matrix_gps/finitely_generated.py  # 1 doctest failed
sage -t --long --warn-long 37.3 src/sage/schemes/curves/curve.py  # 1 doctest failed

@videlec
Copy link
Contributor Author

videlec commented Jul 20, 2017

comment:6

Replying to @videlec:

doctest failures...

Most are because of #23402... so they are fixed there.

@mkoeppe mkoeppe removed this from the sage-8.1 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants