New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toy implementation of F5 algorithm #23461
Comments
Branch: u/TristanVaccon/toy_F5 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed keywords from none to sd87 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
According to me, your file could be much more educational that it is currently. Maybe, you should explain more basic concepts and ideas (such as signatures), explain notations and add more comments within your code. Another thing you could do is to detail (in the first doctest) step by step the execution of the F5 algorithm on a working simple example. Other small comments:
|
comment:8
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Thank you very much for your comments and suggestions! I have made the corresponding corrections. |
comment:12
you need to add a \ (for obscure technical reasons..) as follows
should now be replaced by
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Thank you very much for the comment. I have tried to update accordingly. |
comment:15
same thing here (replace by
And here (and almost everywhere !), there should be no empty line at the start of a documentation
|
This ticket implements Faugère's F5 algorithm.
CC: @xcaruso
Component: commutative algebra
Keywords: sd87
Author: Tristan Vaccon
Branch/Commit: u/TristanVaccon/toy_F5 @
78f0d49
Issue created by migration from https://trac.sagemath.org/ticket/23461
The text was updated successfully, but these errors were encountered: