Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square roots that create extensions (extend=True as for integers) for rational number field #23462

Open
DavidAyotte opened this issue Jul 18, 2017 · 13 comments

Comments

@DavidAyotte
Copy link
Member

We are implementing square roots that create extensions for elements in rational number field. The code should return the equivalent of the element b in the code below :

sage: P.<x> = QQ[]
sage: K.<a> = NumberField(x^2 - 7)
sage: Q.<y> = K[]
sage: E.<b> = K.extension(y^2 - a)
sage: b^2
a

CC: @kevinywlui

Component: number fields

Keywords: square roots, sd87

Branch/Commit: u/davidayotte/square_roots_that_create_extensions__extend_true_as_for_integers__for_rational_number_field @ 740fd54

Issue created by migration from https://trac.sagemath.org/ticket/23462

@DavidAyotte

This comment has been minimized.

@DavidAyotte DavidAyotte self-assigned this Jul 18, 2017
@DavidAyotte
Copy link
Member Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a5d2d40added some doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Commit: a5d2d40

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

2d98ff3the user can now specify the name of the square root

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Changed commit from a5d2d40 to 2d98ff3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

92b1057nth root that create extension but it does not work

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Changed commit from 2d98ff3 to 92b1057

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

1779b63implemented nth root that create extension and add doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2017

Changed commit from 92b1057 to 1779b63

@DavidAyotte
Copy link
Member Author

comment:9

I don't think it's the best algorithm, because it's kind of slow.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

740fd54Square roots and nth roots working

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2017

Changed commit from 1779b63 to 740fd54

@mkoeppe mkoeppe removed this from the sage-8.1 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants