Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute conductor of abelian fields #23499

Closed
sagetrac-jwj mannequin opened this issue Jul 20, 2017 · 20 comments
Closed

Compute conductor of abelian fields #23499

sagetrac-jwj mannequin opened this issue Jul 20, 2017 · 20 comments

Comments

@sagetrac-jwj
Copy link
Mannequin

sagetrac-jwj mannequin commented Jul 20, 2017

Add functionality to test if a number field is abelian, and if so, find its conductor. Covers part of ticket #9407

Depends on #23474

Component: number fields

Keywords: sd87

Author: John Jones

Branch/Commit: e966b85

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23499

@sagetrac-jwj sagetrac-jwj mannequin added this to the sage-8.1 milestone Jul 20, 2017
@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 20, 2017

Branch: u/jwj/ab2

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 20, 2017

Commit: a31c475

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 20, 2017

Changed keywords from none to sd87

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 20, 2017

New commits:

a31c475Fix ticket 23499 by adding functions to test if a number field is

@sagetrac-jwj sagetrac-jwj mannequin added the s: needs review label Jul 20, 2017
@sagetrac-fli
Copy link
Mannequin

sagetrac-fli mannequin commented Jul 21, 2017

Changed dependencies from 23474 to #23474

@sagetrac-abourgeois
Copy link
Mannequin

sagetrac-abourgeois mannequin commented Jul 22, 2017

Changed branch from u/jwj/ab2 to u/abourgeois/ab2

@sagetrac-abourgeois
Copy link
Mannequin

sagetrac-abourgeois mannequin commented Jul 22, 2017

comment:5

All tests pass!

I removed the text "Integer which is the conductor of the field." following INPUT, as it did not belong there.


New commits:

a455648Fix Input of conductor method in the documentation

@sagetrac-abourgeois
Copy link
Mannequin

sagetrac-abourgeois mannequin commented Jul 22, 2017

Changed commit from a31c475 to a455648

@fchapoton
Copy link
Contributor

comment:6

bad syntax for the raise statement, not compatible with python 3

And there was no reviewer name...

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 29, 2017

Changed branch from u/abourgeois/ab2 to u/jwj/ab2

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 29, 2017

comment:8

Fixed syntax of raise statement.


New commits:

a963561Fix raising of error to python 3 syntax

@sagetrac-jwj
Copy link
Mannequin Author

sagetrac-jwj mannequin commented Jul 29, 2017

Changed commit from a455648 to a963561

@roed314
Copy link
Contributor

roed314 commented Aug 4, 2017

Changed branch from u/jwj/ab2 to u/roed/ab2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

ce00f44Undo doctest change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2017

Changed commit from a963561 to ce00f44

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2017

Changed commit from ce00f44 to e966b85

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

e966b85Style fixes and generalize square-of-prime check

@roed314
Copy link
Contributor

roed314 commented Aug 4, 2017

comment:13

I ran all tests, made a few style changes and changed [1,4,9,25,49,121] to more general code. If you're happy with the changes, feel free to set this to positive review.

@roed314
Copy link
Contributor

roed314 commented Aug 4, 2017

Reviewer: David Roe

@vbraun
Copy link
Member

vbraun commented Aug 11, 2017

Changed branch from u/roed/ab2 to e966b85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants